From af79925c8337b92cc40837a9047c8faedb6804c8 Mon Sep 17 00:00:00 2001 From: Ian Craig Date: Fri, 26 Mar 2021 11:15:09 -0700 Subject: [PATCH 1/2] Ensure error is logged when Closure fails --- src/closure-compiler-plugin.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/closure-compiler-plugin.js b/src/closure-compiler-plugin.js index 42a89df..6d14c29 100644 --- a/src/closure-compiler-plugin.js +++ b/src/closure-compiler-plugin.js @@ -968,10 +968,12 @@ class ClosureCompilerPlugin { compilerProcess.on('close', (exitCode) => { if (stdErrData instanceof Error) { - this.reportErrors({ + this.reportErrors(compilation, [ + { level: 'error', description: stdErrData.message, - }); + } + ]); reject(); return; } @@ -1007,6 +1009,13 @@ class ClosureCompilerPlugin { this.reportErrors(compilation, errors); // TODO(ChadKillingsworth) Figure out how to report the stats + } else if (exitCode > 0) { + this.reportErrors(compilation, [ + { + level: 'error', + description: `Closure compiler exited with code ${exitCode}.`, + } + ]); } if (exitCode > 0) { From f548d4ae3443a64913af7134b6095f3895160b4d Mon Sep 17 00:00:00 2001 From: Ian Craig Date: Fri, 26 Mar 2021 12:00:50 -0700 Subject: [PATCH 2/2] Fix prettier errors --- src/closure-compiler-plugin.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/closure-compiler-plugin.js b/src/closure-compiler-plugin.js index 6d14c29..d04bca3 100644 --- a/src/closure-compiler-plugin.js +++ b/src/closure-compiler-plugin.js @@ -970,9 +970,9 @@ class ClosureCompilerPlugin { if (stdErrData instanceof Error) { this.reportErrors(compilation, [ { - level: 'error', - description: stdErrData.message, - } + level: 'error', + description: stdErrData.message, + }, ]); reject(); return; @@ -1014,7 +1014,7 @@ class ClosureCompilerPlugin { { level: 'error', description: `Closure compiler exited with code ${exitCode}.`, - } + }, ]); }