Skip to content

Commit 9d009b3

Browse files
fix: better types
1 parent 08c9f3e commit 9d009b3

File tree

5 files changed

+24
-24
lines changed

5 files changed

+24
-24
lines changed

src/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const { minify: minifyWorker } = require("./minify");
8787
* @param {Input} input
8888
* @param {RawSourceMap | undefined} sourceMap
8989
* @param {InferDefaultType<T>} minifyOptions
90-
* @returns {Promise<MinimizedResult>}
90+
* @returns {Promise<MinimizedResult> | MinimizedResult}
9191
*/
9292

9393
/**

src/utils.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ function throttleAll(limit, tasks) {
7070
/**
7171
* @param {Input} input
7272
* @param {RawSourceMap | undefined} sourceMap
73-
* @param {CustomOptions} minimizerOptions
73+
* @param {CustomOptions} [minimizerOptions]
7474
* @return {Promise<MinimizedResult>}
7575
*/
7676
async function cssnanoMinify(
@@ -192,7 +192,7 @@ cssnanoMinify.supportsWorkerThreads = () => true;
192192
/**
193193
* @param {Input} input
194194
* @param {RawSourceMap | undefined} sourceMap
195-
* @param {CustomOptions} minimizerOptions
195+
* @param {CustomOptions} [minimizerOptions]
196196
* @return {Promise<MinimizedResult>}
197197
*/
198198
async function cssoMinify(input, sourceMap, minimizerOptions) {
@@ -221,7 +221,7 @@ cssoMinify.supportsWorkerThreads = () => true;
221221
/**
222222
* @param {Input} input
223223
* @param {RawSourceMap | undefined} sourceMap
224-
* @param {CustomOptions} minimizerOptions
224+
* @param {CustomOptions} [minimizerOptions]
225225
* @return {Promise<MinimizedResult>}
226226
*/
227227
async function cleanCssMinify(input, sourceMap, minimizerOptions) {
@@ -266,7 +266,7 @@ cleanCssMinify.supportsWorkerThreads = () => true;
266266
/**
267267
* @param {Input} input
268268
* @param {RawSourceMap | undefined} sourceMap
269-
* @param {CustomOptions} minimizerOptions
269+
* @param {CustomOptions} [minimizerOptions]
270270
* @return {Promise<MinimizedResult>}
271271
*/
272272
async function esbuildMinify(input, sourceMap, minimizerOptions) {
@@ -360,7 +360,7 @@ esbuildMinify.supportsWorkerThreads = () => false;
360360
/**
361361
* @param {Input} input
362362
* @param {RawSourceMap | undefined} sourceMap
363-
* @param {CustomOptions} minimizerOptions
363+
* @param {CustomOptions} [minimizerOptions]
364364
* @return {Promise<MinimizedResult>}
365365
*/
366366
async function parcelCssMinify(input, sourceMap, minimizerOptions) {
@@ -406,7 +406,7 @@ parcelCssMinify.supportsWorkerThreads = () => false;
406406
/**
407407
* @param {Input} input
408408
* @param {RawSourceMap | undefined} sourceMap
409-
* @param {CustomOptions} minimizerOptions
409+
* @param {CustomOptions} [minimizerOptions]
410410
* @return {Promise<MinimizedResult>}
411411
*/
412412
async function lightningCssMinify(input, sourceMap, minimizerOptions) {
@@ -452,7 +452,7 @@ lightningCssMinify.supportsWorkerThreads = () => false;
452452
/**
453453
* @param {Input} input
454454
* @param {RawSourceMap | undefined} sourceMap
455-
* @param {CustomOptions} minimizerOptions
455+
* @param {CustomOptions} [minimizerOptions]
456456
* @return {Promise<MinimizedResult>}
457457
*/
458458
async function swcMinify(input, sourceMap, minimizerOptions) {

test/minify-option.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ describe('"minify" option', () => {
152152
{ test: ".three{background: white;}" },
153153
],
154154
minify: [
155-
async (data, inputMap, minimizerOptions) => {
155+
(data, inputMap, minimizerOptions) => {
156156
const [input] = Object.values(data);
157157
return {
158158
code: `${input}\n.one{color: red;}\n${minimizerOptions.test}\n`,

types/index.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ type BasicMinimizerImplementation<T> = (
179179
input: Input,
180180
sourceMap: RawSourceMap | undefined,
181181
minifyOptions: InferDefaultType<T>,
182-
) => Promise<MinimizedResult>;
182+
) => Promise<MinimizedResult> | MinimizedResult;
183183
type MinimizeFunctionHelpers = {
184184
supportsWorkerThreads?: (() => boolean | undefined) | undefined;
185185
};

types/utils.d.ts

+14-14
Original file line numberDiff line numberDiff line change
@@ -26,97 +26,97 @@ export function memoize<T>(fn: (() => any) | undefined): () => T;
2626
/**
2727
* @param {Input} input
2828
* @param {RawSourceMap | undefined} sourceMap
29-
* @param {CustomOptions} minimizerOptions
29+
* @param {CustomOptions} [minimizerOptions]
3030
* @return {Promise<MinimizedResult>}
3131
*/
3232
export function cssnanoMinify(
3333
input: Input,
3434
sourceMap: RawSourceMap | undefined,
35-
minimizerOptions?: CustomOptions,
35+
minimizerOptions?: import("./index.js").CustomOptions | undefined,
3636
): Promise<MinimizedResult>;
3737
export namespace cssnanoMinify {
3838
function supportsWorkerThreads(): boolean;
3939
}
4040
/**
4141
* @param {Input} input
4242
* @param {RawSourceMap | undefined} sourceMap
43-
* @param {CustomOptions} minimizerOptions
43+
* @param {CustomOptions} [minimizerOptions]
4444
* @return {Promise<MinimizedResult>}
4545
*/
4646
export function cssoMinify(
4747
input: Input,
4848
sourceMap: RawSourceMap | undefined,
49-
minimizerOptions: CustomOptions,
49+
minimizerOptions?: import("./index.js").CustomOptions | undefined,
5050
): Promise<MinimizedResult>;
5151
export namespace cssoMinify {
5252
function supportsWorkerThreads(): boolean;
5353
}
5454
/**
5555
* @param {Input} input
5656
* @param {RawSourceMap | undefined} sourceMap
57-
* @param {CustomOptions} minimizerOptions
57+
* @param {CustomOptions} [minimizerOptions]
5858
* @return {Promise<MinimizedResult>}
5959
*/
6060
export function cleanCssMinify(
6161
input: Input,
6262
sourceMap: RawSourceMap | undefined,
63-
minimizerOptions: CustomOptions,
63+
minimizerOptions?: import("./index.js").CustomOptions | undefined,
6464
): Promise<MinimizedResult>;
6565
export namespace cleanCssMinify {
6666
function supportsWorkerThreads(): boolean;
6767
}
6868
/**
6969
* @param {Input} input
7070
* @param {RawSourceMap | undefined} sourceMap
71-
* @param {CustomOptions} minimizerOptions
71+
* @param {CustomOptions} [minimizerOptions]
7272
* @return {Promise<MinimizedResult>}
7373
*/
7474
export function esbuildMinify(
7575
input: Input,
7676
sourceMap: RawSourceMap | undefined,
77-
minimizerOptions: CustomOptions,
77+
minimizerOptions?: import("./index.js").CustomOptions | undefined,
7878
): Promise<MinimizedResult>;
7979
export namespace esbuildMinify {
8080
function supportsWorkerThreads(): boolean;
8181
}
8282
/**
8383
* @param {Input} input
8484
* @param {RawSourceMap | undefined} sourceMap
85-
* @param {CustomOptions} minimizerOptions
85+
* @param {CustomOptions} [minimizerOptions]
8686
* @return {Promise<MinimizedResult>}
8787
*/
8888
export function parcelCssMinify(
8989
input: Input,
9090
sourceMap: RawSourceMap | undefined,
91-
minimizerOptions: CustomOptions,
91+
minimizerOptions?: import("./index.js").CustomOptions | undefined,
9292
): Promise<MinimizedResult>;
9393
export namespace parcelCssMinify {
9494
function supportsWorkerThreads(): boolean;
9595
}
9696
/**
9797
* @param {Input} input
9898
* @param {RawSourceMap | undefined} sourceMap
99-
* @param {CustomOptions} minimizerOptions
99+
* @param {CustomOptions} [minimizerOptions]
100100
* @return {Promise<MinimizedResult>}
101101
*/
102102
export function lightningCssMinify(
103103
input: Input,
104104
sourceMap: RawSourceMap | undefined,
105-
minimizerOptions: CustomOptions,
105+
minimizerOptions?: import("./index.js").CustomOptions | undefined,
106106
): Promise<MinimizedResult>;
107107
export namespace lightningCssMinify {
108108
function supportsWorkerThreads(): boolean;
109109
}
110110
/**
111111
* @param {Input} input
112112
* @param {RawSourceMap | undefined} sourceMap
113-
* @param {CustomOptions} minimizerOptions
113+
* @param {CustomOptions} [minimizerOptions]
114114
* @return {Promise<MinimizedResult>}
115115
*/
116116
export function swcMinify(
117117
input: Input,
118118
sourceMap: RawSourceMap | undefined,
119-
minimizerOptions: CustomOptions,
119+
minimizerOptions?: import("./index.js").CustomOptions | undefined,
120120
): Promise<MinimizedResult>;
121121
export namespace swcMinify {
122122
function supportsWorkerThreads(): boolean;

0 commit comments

Comments
 (0)