Skip to content

Commit c0c8b96

Browse files
refactor: code
1 parent bc6dd99 commit c0c8b96

File tree

5 files changed

+28
-28
lines changed

5 files changed

+28
-28
lines changed

src/index.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const {
1515
} = require("./utils");
1616

1717
const schema = require("./options.json");
18-
const { minify: minifyWorker } = require("./minify");
18+
const { minify } = require("./minify");
1919

2020
/** @typedef {import("schema-utils/declarations/validate").Schema} Schema */
2121
/** @typedef {import("webpack").Compiler} Compiler */
@@ -134,7 +134,7 @@ const { minify: minifyWorker } = require("./minify");
134134

135135
/**
136136
* @template T
137-
* @typedef {JestWorker & { transform: (options: string) => InternalResult, minify: (options: InternalOptions<T>) => InternalResult }} MinimizerWorker
137+
* @typedef {JestWorker & { transform: (options: string) => Promise<InternalResult>, minify: (options: InternalOptions<T>) => Promise<InternalResult> }} MinimizerWorker
138138
*/
139139

140140
/**
@@ -578,7 +578,7 @@ class CssMinimizerPlugin {
578578
try {
579579
result = await (getWorker
580580
? getWorker().transform(getSerializeJavascript()(options))
581-
: minifyWorker(options));
581+
: minify(options));
582582
} catch (error) {
583583
const hasSourceMap =
584584
inputSourceMap && CssMinimizerPlugin.isSourceMap(inputSourceMap);

src/minify.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* @param {import("./index.js").InternalOptions<T>} options
77
* @returns {Promise<InternalResult>}
88
*/
9-
const minify = async (options) => {
9+
async function minify(options) {
1010
const minifyFns = Array.isArray(options.minimizer.implementation)
1111
? options.minimizer.implementation
1212
: [options.minimizer.implementation];
@@ -59,7 +59,7 @@ const minify = async (options) => {
5959
}
6060

6161
return result;
62-
};
62+
}
6363

6464
/**
6565
* @param {string} options

src/utils.js

+7-7
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function throttleAll(limit, tasks) {
6969
/* istanbul ignore next */
7070
/**
7171
* @param {Input} input
72-
* @param {RawSourceMap | undefined} sourceMap
72+
* @param {RawSourceMap} [sourceMap]
7373
* @param {CustomOptions} [minimizerOptions]
7474
* @return {Promise<MinimizedResult>}
7575
*/
@@ -191,7 +191,7 @@ cssnanoMinify.supportsWorkerThreads = () => true;
191191
/* istanbul ignore next */
192192
/**
193193
* @param {Input} input
194-
* @param {RawSourceMap | undefined} sourceMap
194+
* @param {RawSourceMap} [sourceMap]
195195
* @param {CustomOptions} [minimizerOptions]
196196
* @return {Promise<MinimizedResult>}
197197
*/
@@ -220,7 +220,7 @@ cssoMinify.supportsWorkerThreads = () => true;
220220
/* istanbul ignore next */
221221
/**
222222
* @param {Input} input
223-
* @param {RawSourceMap | undefined} sourceMap
223+
* @param {RawSourceMap} [sourceMap]
224224
* @param {CustomOptions} [minimizerOptions]
225225
* @return {Promise<MinimizedResult>}
226226
*/
@@ -265,7 +265,7 @@ cleanCssMinify.supportsWorkerThreads = () => true;
265265
/* istanbul ignore next */
266266
/**
267267
* @param {Input} input
268-
* @param {RawSourceMap | undefined} sourceMap
268+
* @param {RawSourceMap} [sourceMap]
269269
* @param {CustomOptions} [minimizerOptions]
270270
* @return {Promise<MinimizedResult>}
271271
*/
@@ -359,7 +359,7 @@ esbuildMinify.supportsWorkerThreads = () => false;
359359
/* istanbul ignore next */
360360
/**
361361
* @param {Input} input
362-
* @param {RawSourceMap | undefined} sourceMap
362+
* @param {RawSourceMap} [sourceMap]
363363
* @param {CustomOptions} [minimizerOptions]
364364
* @return {Promise<MinimizedResult>}
365365
*/
@@ -405,7 +405,7 @@ parcelCssMinify.supportsWorkerThreads = () => false;
405405
/* istanbul ignore next */
406406
/**
407407
* @param {Input} input
408-
* @param {RawSourceMap | undefined} sourceMap
408+
* @param {RawSourceMap} [sourceMap]
409409
* @param {CustomOptions} [minimizerOptions]
410410
* @return {Promise<MinimizedResult>}
411411
*/
@@ -451,7 +451,7 @@ lightningCssMinify.supportsWorkerThreads = () => false;
451451
/* istanbul ignore next */
452452
/**
453453
* @param {Input} input
454-
* @param {RawSourceMap | undefined} sourceMap
454+
* @param {RawSourceMap} [sourceMap]
455455
* @param {CustomOptions} [minimizerOptions]
456456
* @return {Promise<MinimizedResult>}
457457
*/

types/index.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -222,8 +222,8 @@ type BasePluginOptions = {
222222
parallel?: Parallel;
223223
};
224224
type MinimizerWorker<T> = JestWorker & {
225-
transform: (options: string) => InternalResult;
226-
minify: (options: InternalOptions<T>) => InternalResult;
225+
transform: (options: string) => Promise<InternalResult>;
226+
minify: (options: InternalOptions<T>) => Promise<InternalResult>;
227227
};
228228
type ProcessOptionsExtender =
229229
| ProcessOptions

types/utils.d.ts

+14-14
Original file line numberDiff line numberDiff line change
@@ -25,97 +25,97 @@ export function throttleAll<T>(limit: number, tasks: Task<T>[]): Promise<T[]>;
2525
export function memoize<T>(fn: (() => any) | undefined): () => T;
2626
/**
2727
* @param {Input} input
28-
* @param {RawSourceMap | undefined} sourceMap
28+
* @param {RawSourceMap} [sourceMap]
2929
* @param {CustomOptions} [minimizerOptions]
3030
* @return {Promise<MinimizedResult>}
3131
*/
3232
export function cssnanoMinify(
3333
input: Input,
34-
sourceMap: RawSourceMap | undefined,
34+
sourceMap?: import("@jridgewell/trace-mapping").EncodedSourceMap | undefined,
3535
minimizerOptions?: import("./index.js").CustomOptions | undefined,
3636
): Promise<MinimizedResult>;
3737
export namespace cssnanoMinify {
3838
function supportsWorkerThreads(): boolean;
3939
}
4040
/**
4141
* @param {Input} input
42-
* @param {RawSourceMap | undefined} sourceMap
42+
* @param {RawSourceMap} [sourceMap]
4343
* @param {CustomOptions} [minimizerOptions]
4444
* @return {Promise<MinimizedResult>}
4545
*/
4646
export function cssoMinify(
4747
input: Input,
48-
sourceMap: RawSourceMap | undefined,
48+
sourceMap?: import("@jridgewell/trace-mapping").EncodedSourceMap | undefined,
4949
minimizerOptions?: import("./index.js").CustomOptions | undefined,
5050
): Promise<MinimizedResult>;
5151
export namespace cssoMinify {
5252
function supportsWorkerThreads(): boolean;
5353
}
5454
/**
5555
* @param {Input} input
56-
* @param {RawSourceMap | undefined} sourceMap
56+
* @param {RawSourceMap} [sourceMap]
5757
* @param {CustomOptions} [minimizerOptions]
5858
* @return {Promise<MinimizedResult>}
5959
*/
6060
export function cleanCssMinify(
6161
input: Input,
62-
sourceMap: RawSourceMap | undefined,
62+
sourceMap?: import("@jridgewell/trace-mapping").EncodedSourceMap | undefined,
6363
minimizerOptions?: import("./index.js").CustomOptions | undefined,
6464
): Promise<MinimizedResult>;
6565
export namespace cleanCssMinify {
6666
function supportsWorkerThreads(): boolean;
6767
}
6868
/**
6969
* @param {Input} input
70-
* @param {RawSourceMap | undefined} sourceMap
70+
* @param {RawSourceMap} [sourceMap]
7171
* @param {CustomOptions} [minimizerOptions]
7272
* @return {Promise<MinimizedResult>}
7373
*/
7474
export function esbuildMinify(
7575
input: Input,
76-
sourceMap: RawSourceMap | undefined,
76+
sourceMap?: import("@jridgewell/trace-mapping").EncodedSourceMap | undefined,
7777
minimizerOptions?: import("./index.js").CustomOptions | undefined,
7878
): Promise<MinimizedResult>;
7979
export namespace esbuildMinify {
8080
function supportsWorkerThreads(): boolean;
8181
}
8282
/**
8383
* @param {Input} input
84-
* @param {RawSourceMap | undefined} sourceMap
84+
* @param {RawSourceMap} [sourceMap]
8585
* @param {CustomOptions} [minimizerOptions]
8686
* @return {Promise<MinimizedResult>}
8787
*/
8888
export function parcelCssMinify(
8989
input: Input,
90-
sourceMap: RawSourceMap | undefined,
90+
sourceMap?: import("@jridgewell/trace-mapping").EncodedSourceMap | undefined,
9191
minimizerOptions?: import("./index.js").CustomOptions | undefined,
9292
): Promise<MinimizedResult>;
9393
export namespace parcelCssMinify {
9494
function supportsWorkerThreads(): boolean;
9595
}
9696
/**
9797
* @param {Input} input
98-
* @param {RawSourceMap | undefined} sourceMap
98+
* @param {RawSourceMap} [sourceMap]
9999
* @param {CustomOptions} [minimizerOptions]
100100
* @return {Promise<MinimizedResult>}
101101
*/
102102
export function lightningCssMinify(
103103
input: Input,
104-
sourceMap: RawSourceMap | undefined,
104+
sourceMap?: import("@jridgewell/trace-mapping").EncodedSourceMap | undefined,
105105
minimizerOptions?: import("./index.js").CustomOptions | undefined,
106106
): Promise<MinimizedResult>;
107107
export namespace lightningCssMinify {
108108
function supportsWorkerThreads(): boolean;
109109
}
110110
/**
111111
* @param {Input} input
112-
* @param {RawSourceMap | undefined} sourceMap
112+
* @param {RawSourceMap} [sourceMap]
113113
* @param {CustomOptions} [minimizerOptions]
114114
* @return {Promise<MinimizedResult>}
115115
*/
116116
export function swcMinify(
117117
input: Input,
118-
sourceMap: RawSourceMap | undefined,
118+
sourceMap?: import("@jridgewell/trace-mapping").EncodedSourceMap | undefined,
119119
minimizerOptions?: import("./index.js").CustomOptions | undefined,
120120
): Promise<MinimizedResult>;
121121
export namespace swcMinify {

0 commit comments

Comments
 (0)