refactor: better

Author: alexander-akait

src/index.js

@@ -596,24 +596,24 @@ class TerserPlugin {
             );
           }
 
-          let shebang;
+          if (output.code) {
+            let shebang;
 
-          if (
-            /** @type {ExtractCommentsObject} */
-            (this.options.extractComments).banner !== false &&
-            output.extractedComments &&
-            output.extractedComments.length > 0 &&
-            output.code.startsWith("#!")
-          ) {
-            const firstNewlinePosition = output.code.indexOf("\n");
+            if (
+              /** @type {ExtractCommentsObject} */
+              (this.options.extractComments).banner !== false &&
+              output.extractedComments &&
+              output.extractedComments.length > 0 &&
+              output.code.startsWith("#!")
+            ) {
+              const firstNewlinePosition = output.code.indexOf("\n");
 
-            shebang = output.code.slice(0, Math.max(0, firstNewlinePosition));
-            output.code = output.code.slice(
-              Math.max(0, firstNewlinePosition + 1),
-            );
-          }
+              shebang = output.code.slice(0, Math.max(0, firstNewlinePosition));
+              output.code = output.code.slice(
+                Math.max(0, firstNewlinePosition + 1),
+              );
+            }
 
-          if (output.code) {
             if (output.map) {
               output.source = new SourceMapSource(
                 output.code,

test/__snapshots__/minify-option.test.js.snap

@@ -11,7 +11,7 @@ error",
 
 exports[`minify option should output errors and warning: warnings 1`] = `
 Array [
-  "Warning: Error: warning",
+  "Warning: warning",
 ]
 `;
 

test/minify-option.test.js

@@ -162,8 +162,8 @@ describe("minify option", () => {
 
     new TerserPlugin({
       minify: () => ({
-        errors: [new Error("error")],
-        warnings: [new Error("warning")],
+        errors: ["error"],
+        warnings: ["warning"],
       }),
     }).apply(compiler);