fix: update redirect logic for URLs ending with '/' in getFilenameFromUrl

Author: bjohansebas

.github/workflows/nodejs.yml

@@ -5,6 +5,7 @@ on:
     branches:
       - main
       - next
+      - send-fix
   pull_request:
     branches:
       - main

src/middleware.js

@@ -505,7 +505,6 @@ function wrapper(context) {
         /** @type {string} */ (getRequestURL(req)),
         extra,
       );
-
       if (extra.errorCode) {
         if (extra.errorCode === 403) {
           context.logger.error(`Malicious path "${filename}".`);

src/utils/getFilenameFromUrl.js

@@ -43,7 +43,7 @@ const UP_PATH_REGEXP = /(?:^|[\\/])\.\.(?:[\\/]|$)/;
  */
 
 // TODO refactor me in the next major release, this function should return `{ filename, stats, error }`
-// TODO fix redirect logic when `/` at the end, like https://github.com/pillarjs/send/blob/master/index.js#L586
+// TODO fix redirect logic when `/` at the end, like https://github.com/pillarjs/send/blob/121dda811bae6420ce08171b10685d19c4e53059/index.js#L426
 /**
  * @template {IncomingMessage} Request
  * @template {ServerResponse} Response
@@ -64,6 +64,13 @@ function getFilenameFromUrl(context, url, extra = {}) {
   try {
     // The `url` property of the `request` is contains only  `pathname`, `search` and `hash`
     urlObject = memoizedParse(url, false, true);
+
+    if (
+      urlObject?.pathname &&
+      urlObject.pathname[urlObject.pathname.length - 1] === "/"
+    ) {
+      urlObject.pathname = path.join(urlObject.pathname, "index.html");
+    }
   } catch {
     return;
   }
@@ -110,10 +117,7 @@ function getFilenameFromUrl(context, url, extra = {}) {
       // `/complex/foo.js` => `foo.js`
       // and add outputPath
       // `foo.js` => `/home/user/my-project/dist/foo.js`
-      filename = path.join(
-        outputPath,
-        pathname.slice(publicPathPathname.length),
-      );
+      filename = path.join(outputPath, pathname);
 
       try {
         extra.stats = context.outputFileSystem.statSync(filename);