-
-
Notifications
You must be signed in to change notification settings - Fork 62
Labels
bugSomething isn't workingSomething isn't working
Description
Browsertrix Version
v1.21.0
What did you expect to happen? What happened instead?
With the crawler now being on 1.10.x, the naive comparisons for minimum crawler versions are broken, eg:
# if set, will restrict autoclick behavior to image names that are >= this value
min_autoclick_crawler_image: "docker.io/webrecorder/browsertrix-crawler:1.5.0"
# if set, will restrict seed files to image names that are >= this value
min_seed_file_crawler_image: "docker.io/webrecorder/browsertrix-crawler:1.7.0"
will not work correctly with browsertrix-crawler:1.10.x since the comparison we use is just alpha.
The comparison should use something like: https://packaging.pypa.io/en/stable/version.html instead
Reproduction instructions
- Set a crawler channel to browsertrix-crawler:1.10.2
- Observe the URL seed list option returns an error due to failed version check.
Screenshots / Video
No response
Environment
No response
Additional details
No response
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
In Review