[bug] fixed checking of the template strings in tsr-detect-non-literal-require rule

webschik · webschik · commit 770262ddb6cd · 2018-10-09T21:24:09.000+02:00
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tslint-config-security",
-  "version": "1.6.0",
+  "version": "1.7.0",
   "description": "TSLint security rules",
   "main": "./index.js",
   "scripts": {
diff --git a/src/rules/tsrDetectNonLiteralRequireRule.ts b/src/rules/tsrDetectNonLiteralRequireRule.ts
@@ -16,7 +16,8 @@ class RuleWalker extends Lint.RuleWalker {
             expression &&
             expression.text === 'require' &&
             firstArgument &&
-            firstArgument.kind !== ts.SyntaxKind.StringLiteral
+            firstArgument.kind !== ts.SyntaxKind.StringLiteral &&
+            firstArgument.kind !== ts.SyntaxKind.NoSubstitutionTemplateLiteral
         ) {
             this.addFailureAtNode(node, 'Found non-literal argument in require');
         }
diff --git a/test/rules/tsr-detect-non-literal-require/default/test.ts.lint b/test/rules/tsr-detect-non-literal-require/default/test.ts.lint
@@ -1,3 +1,6 @@
 require('path');
+require(`path`);
+require(`${path}`);
+~~~~~~~~~~~~~~~~~~    [Found non-literal argument in require]
 require(path);
 ~~~~~~~~~~~~~    [Found non-literal argument in require]

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "tslint-config-security",`
`3`		`- "version": "1.6.0",`
	`3`	`+ "version": "1.7.0",`
`4`	`4`	`"description": "TSLint security rules",`
`5`	`5`	`"main": "./index.js",`
`6`	`6`	`"scripts": {`