Merge pull request #213 from SgLy/fix-invalid-numeric-for

LastLeaf · web-flow · commit 09c5aa51ec6e · 2024-11-13T18:53:10.000+08:00
fix(core): ensure numeric for-value to be valid array length
diff --git a/glass-easel/src/tmpl/range_list_diff.ts b/glass-easel/src/tmpl/range_list_diff.ts
@@ -71,9 +71,11 @@ export class RangeListManager {
         this.ownerShadowRoot.getHostNode(),
         this.elem,
       )
-      items = new Array<string>(dataList)
+      const length =
+        Number.isSafeInteger(dataList) && dataList >= 0 && dataList < 2 ** 32 ? dataList : 0
+      items = new Array<string>(length)
       indexes = null
-      for (let i = 0; i < dataList; i += 1) {
+      for (let i = 0; i < length; i += 1) {
         items[i] = i
       }
     } else {

Original file line number	Diff line number	Diff line change
`@@ -71,9 +71,11 @@ export class RangeListManager {`
`71`	`71`	`this.ownerShadowRoot.getHostNode(),`
`72`	`72`	`this.elem,`
`73`	`73`	`)`
`74`		`- items = new Array<string>(dataList)`
	`74`	`+ const length =`
	`75`	`+ Number.isSafeInteger(dataList) && dataList >= 0 && dataList < 2 ** 32 ? dataList : 0`
	`76`	`+ items = new Array<string>(length)`
`75`	`77`	`indexes = null`
`76`		`- for (let i = 0; i < dataList; i += 1) {`
	`78`	`+ for (let i = 0; i < length; i += 1) {`
`77`	`79`	`items[i] = i`
`78`	`80`	`}`
`79`	`81`	`} else {`