Merge pull request #253 from wechat-miniprogram/feat-make-properties-public

Make some properties public & hide private properties

Author: Tidyzq

glass-easel/src/behavior.ts

@@ -140,11 +140,10 @@ export class BehaviorBuilder<
   TPendingChainingFilter extends ChainingFilterType = never,
   TExtraThisFields extends DataList = Empty,
 > {
+  public is: string | undefined
   /** @internal */
   _$ownerSpace: ComponentSpace
   /** @internal */
-  _$is: string | undefined
-  /** @internal */
   _$behaviors: (string | GeneralBehavior)[] = []
   /** @internal */
   _$chainingFilter?: (chain: GeneralBehaviorBuilder) => any
@@ -193,7 +192,7 @@ export class BehaviorBuilder<
 
   /** @internal */
   constructor(is: string | undefined, ownerSpace: ComponentSpace) {
-    this._$is = is
+    this.is = is
     this._$ownerSpace = ownerSpace
   }
 
@@ -370,7 +369,7 @@ export class BehaviorBuilder<
     >,
     TChainingFilter
   > {
-    this._$data.push(() => safeCallback('Data Generator', gen, null, [], this._$is) ?? {})
+    this._$data.push(() => safeCallback('Data Generator', gen, null, [], this.is) ?? {})
     return this as any
   }
 
@@ -494,7 +493,7 @@ export class BehaviorBuilder<
       this._$observers.push({ dataPaths: parseMultiPaths(paths as string | string[]), func, once })
     } catch (e) {
       // parse multi paths my throw errors
-      dispatchError(e, `observer`, this._$is)
+      dispatchError(e, `observer`, this.is)
     }
     return this as any
   }
@@ -619,7 +618,7 @@ export class BehaviorBuilder<
     const rawData = def.data
     if (rawData !== undefined) {
       if (typeof rawData === 'function') {
-        this._$data.push(() => safeCallback('Data Generator', rawData, null, [], this._$is) ?? {})
+        this._$data.push(() => safeCallback('Data Generator', rawData, null, [], this.is) ?? {})
       } else {
         this._$staticData = rawData
       }
@@ -657,7 +656,7 @@ export class BehaviorBuilder<
             })
           } catch (e) {
             // parse multi paths may throw errors
-            dispatchError(e, `definition`, this._$is)
+            dispatchError(e, `definition`, this.is)
           }
         }
       } else {
@@ -673,7 +672,7 @@ export class BehaviorBuilder<
             })
           } catch (e) {
             // parse multi paths may throw errors
-            dispatchError(e, `definition`, this._$is)
+            dispatchError(e, `definition`, this.is)
           }
         }
       }
@@ -745,7 +744,7 @@ export class BehaviorBuilder<
     TPendingChainingFilter,
     TExtraThisFields
   > {
-    const is = this._$is
+    const is = this.is
     const behavior = new Behavior(this)
     if (is !== undefined) {
       this._$ownerSpace._$registerBehavior(is, behavior as unknown as GeneralBehavior)
@@ -772,11 +771,11 @@ export class BehaviorBuilder<
    * Finish build, generate a component definition, and register it in the component space
    */
   registerComponent(): ComponentDefinition<TData, TProperty, TMethod> {
-    const is = this._$is
+    const is = this.is
     const behavior = new Behavior(this)
     const compDef = new ComponentDefinition(behavior)
     if (is !== undefined) {
-      this._$ownerSpace._$registerComponent(is, compDef as unknown as GeneralComponentDefinition)
+      this._$ownerSpace.registerComponent(is, compDef as unknown as GeneralComponentDefinition)
     }
     return compDef
   }
@@ -878,7 +877,7 @@ export class Behavior<
     >,
   ) {
     this._$unprepared = true
-    this.is = builder._$is || ''
+    this.is = builder.is || ''
     this.ownerSpace = builder._$ownerSpace
     this._$builder = builder
     this._$flatAncestors = new Set()

glass-easel/src/component_space.ts

@@ -415,8 +415,8 @@ export class ComponentSpace {
     return new BehaviorBuilder(is, this)
   }
 
-  /** @internal */
-  _$registerComponent(is: string, comp: GeneralComponentDefinition) {
+  /** Register a component in this space using an existing definition */
+  registerComponent(is: string, comp: GeneralComponentDefinition) {
     this._$list[is] = comp
     this._$behaviorList[is] = comp.behavior as unknown as GeneralBehavior
     const waiting = this._$listWaiting[is]

glass-easel/src/data_proxy.ts

@@ -495,25 +495,38 @@ export class DataGroup<
 > {
   data: DataWithPropertyValues<TData, TProperty>
   innerData: { [key: string]: DataValue } | null
+  /* @internal */
   private _$comp: ComponentInstance<TData, TProperty, TMethod> | null
+  /* @internal */
   private _$pureDataPattern: RegExp | null
+  /* @internal */
   private _$dataDeepCopy: DeepCopyStrategy
+  /* @internal */
   private _$propertyPassingDeepCopy: DeepCopyStrategy
+  /* @internal */
   private _$reflectToAttributes: boolean
+  /* @internal */
   private _$propFields: { [name: string]: PropertyDefinition }
   /** @internal */
   _$observerTree: DataGroupObserverTree
+  /* @internal */
   private _$observerStatus: boolean[]
+  /* @internal */
   private _$modelBindingListener: { [name: string]: ModelBindingListener } | null = null
+  /* @internal */
   private _$updateListener?: DataUpdateCallback
+  /* @internal */
   private _$pendingChanges: DataChange[] = []
+  /* @internal */
   private _$doingUpdates: {
     prop: PropertyChange[]
     combined: DataChange[]
     count: number
   } | null = null
+  /* @internal */
   private _$recUpdateLevel = 0
 
+  /* @internal */
   private _$generateInnerData(data: { [key: string]: DataValue }) {
     const pureDataPattern = this._$pureDataPattern
     const dataDeepCopy = this._$dataDeepCopy

glass-easel/src/mutation_observer.ts

@@ -87,7 +87,9 @@ export type MutationObserverEvent =
 export type MutationObserverListener<T> = (this: Node, ev: T) => void
 
 export class MutationObserverTarget {
+  /* @internal */
   private _$bound: Node
+  /* @internal */
   private _$subtreeObserversCount = 0
   attrObservers: FuncArr<MutationObserverListener<MutationObserverAttrEvent>> | null = null
   allAttrObservers: FuncArr<MutationObserverListener<MutationObserverAttrEvent>> | null = null
@@ -190,10 +192,15 @@ export class MutationObserverTarget {
  * Further more, it can listen attached/detached events on an element.
  */
 export class MutationObserver {
+  /* @internal */
   private _$listener: MutationObserverListener<MutationObserverEvent> | null
+  /* @internal */
   private _$normalizedListener: MutationObserverListener<MutationObserverEvent> | null
+  /* @internal */
   private _$subtreeListenersCount = 0
+  /* @internal */
   private _$boundFuncArrs: FuncArr<MutationObserverListener<MutationObserverEvent>>[] = []
+  /* @internal */
   private _$boundTarget: MutationObserverTarget | null = null
 
   constructor(listener: (ev: MutationObserverEvent) => void) {