Skip to content

Commit e55c424

Browse files
authored
Merge pull request #262 from wechat-miniprogram/fix-start-overlay-inspect
fix(shadow-sync): fix startOverlayInspect called multiple times
2 parents cc26d24 + 6208936 commit e55c424

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

glass-easel-shadow-sync/src/message_channel.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,11 +618,14 @@ export const MessageChannelDataSide = (
618618
) => publish([ChannelEventType.SET_SCROLL_POSITION, elementId, scrollLeft, scrollTop, duration]),
619619
getPseudoTypes: (elementId: number, cb: (res: string[]) => void) => publish([ChannelEventType.GET_PSEUDO_TYPES, elementId, callback2id(cb)]),
620620
startOverlayInspect: (cb: (event: string, elementId: number | null) => void) => {
621+
if (overlayInspectCallbackId !== null) return
621622
const callbackId = overlayInspectCallbackId = callback2id(cb)
622623
publish([ChannelEventType.START_OVERLAY_INSPECT, callbackId])
623624
},
624625
stopOverlayInspect: () => {
625-
if (overlayInspectCallbackId) releaseCallbackId(overlayInspectCallbackId)
626+
if (overlayInspectCallbackId === null) return
627+
releaseCallbackId(overlayInspectCallbackId)
628+
overlayInspectCallbackId = null
626629
publish([ChannelEventType.STOP_OVERLAY_INSPECT])
627630
},
628631

0 commit comments

Comments
 (0)