Skip to content

Commit 113e377

Browse files
author
zeyu10
committed
resolve sonar: class is part of one cycle containing 2 classes
1 parent 19c31bb commit 113e377

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

rill-flow-dag/olympicene-traversal/src/main/java/com/weibo/rill/flow/olympicene/traversal/DAGOperations.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
import java.util.function.Supplier;
5252

5353
@Slf4j
54-
public class DAGOperations {
54+
public class DAGOperations implements DAGOperationsInterface {
5555
private static final String EXECUTION_ID = "executionId";
5656

5757
private final ExecutorService runnerExecutor;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package com.weibo.rill.flow.olympicene.traversal;
2+
3+
import com.weibo.rill.flow.interfaces.model.task.TaskInfo;
4+
import com.weibo.rill.flow.olympicene.core.model.NotifyInfo;
5+
import com.weibo.rill.flow.olympicene.core.model.dag.DAGInfo;
6+
import com.weibo.rill.flow.olympicene.core.model.dag.DAGInvokeMsg;
7+
import com.weibo.rill.flow.olympicene.core.model.dag.DAGStatus;
8+
import org.apache.commons.lang3.tuple.Pair;
9+
10+
import java.util.Collection;
11+
import java.util.Map;
12+
13+
public interface DAGOperationsInterface {
14+
void finishDAG(String executionId, DAGInfo dagInfo, DAGStatus dagStatus, DAGInvokeMsg dagInvokeMsg);
15+
void finishTaskAsync(String executionId, String taskCategory, NotifyInfo notifyInfo, Map<String, Object> output);
16+
void finishTaskSync(String executionId, String taskCategory, NotifyInfo notifyInfo, Map<String, Object> output);
17+
void runTasks(String executionId, Collection<Pair<TaskInfo, Map<String, Object>>> taskInfoToContexts);
18+
}

rill-flow-dag/olympicene-traversal/src/main/java/com/weibo/rill/flow/olympicene/traversal/DAGTraversal.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public class DAGTraversal {
5656
private final DAGStorageProcedure dagStorageProcedure;
5757
private final ExecutorService traversalExecutor;
5858
@Setter
59-
private DAGOperations dagOperations;
59+
private DAGOperationsInterface dagOperations;
6060
@Setter
6161
private Stasher stasher;
6262

0 commit comments

Comments
 (0)