Fix spurious assert (GH #1279)

noloader · noloader · commit 60f81a77e0c9 · 2024-06-23T11:59:34.000-04:00
diff --git a/nbtheory.cpp b/nbtheory.cpp
@@ -525,9 +525,6 @@ Integer MaurerProvablePrime(RandomNumberGenerator &rng, unsigned int bits)
 
 Integer CRT(const Integer &xp, const Integer &p, const Integer &xq, const Integer &q, const Integer &u)
 {
-	// Callers must ensure p and q are prime, GH #1249
-	CRYPTOPP_ASSERT(IsPrime(p) && IsPrime(q));
-
 	// isn't operator overloading great?
 	return p * (u * (xq-xp) % q) + xp;
 /*

Original file line number	Diff line number	Diff line change
`@@ -525,9 +525,6 @@ Integer MaurerProvablePrime(RandomNumberGenerator &rng, unsigned int bits)`
`525`	`525`
`526`	`526`	`Integer CRT(const Integer &xp, const Integer &p, const Integer &xq, const Integer &q, const Integer &u)`
`527`	`527`	`{`
`528`		`- // Callers must ensure p and q are prime, GH #1249`
`529`		`- CRYPTOPP_ASSERT(IsPrime(p) && IsPrime(q));`
`530`		`-`
`531`	`528`	`// isn't operator overloading great?`
`532`	`529`	`return p * (u * (xq-xp) % q) + xp;`
`533`	`530`	`/*`