WELD-2817 Change how SerializableContextualInstanceImpl#toString operates to avoid possible SO on collections storing cyclical references

manovotn · manovotn · commit db2f6dcf52c6 · 2025-06-18T17:46:18.000+02:00
diff --git a/impl/src/main/java/org/jboss/weld/contexts/SerializableContextualInstanceImpl.java b/impl/src/main/java/org/jboss/weld/contexts/SerializableContextualInstanceImpl.java
@@ -59,7 +59,8 @@ public CreationalContext<I> getCreationalContext() {
 
     @Override
     public String toString() {
-        return "Bean: " + contextual + "; Instance: " + instance + "; CreationalContext: " + creationalContext;
+        return "Bean: " + contextual + "; Instance: " + instance.getClass().getName() + "@"
+                + Integer.toHexString(instance.hashCode()) + "; CreationalContext: " + creationalContext;
     }
 
 }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,8 @@ public CreationalContext<I> getCreationalContext() {`
`59`	`59`
`60`	`60`	`@Override`
`61`	`61`	`public String toString() {`
`62`		`- return "Bean: " + contextual + "; Instance: " + instance + "; CreationalContext: " + creationalContext;`
	`62`	`+ return "Bean: " + contextual + "; Instance: " + instance.getClass().getName() + "@"`
	`63`	`+ + Integer.toHexString(instance.hashCode()) + "; CreationalContext: " + creationalContext;`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`}`