.gitignore - ignore certbot keys #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storing certbot/letsencrypt keys in the repo takes considerable space when having many domains over time I have not fully tested yet, but with those rules we should still keep trace of certbot setup, at disaster this should be good enough to re-create all new certificates at once. and obviously is a security risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing certbot/letsencrypt keys in the repo takes considerable space, specially when having many domains over long time.
...and obviously is a security risk
I have not fully tested yet, but with those rules we should still keep trace of certbot setup, at disaster this should be good enough to re-create all new certificates at once.
There probably is a more elegant way do this, but I think it would be a good idea not to store those keys by default.
Thanks for your great work, this package is very handy and made this world a better place :)