refactor: Consolidate inline imports across entire codebase

Moved all inline imports to top of files per project code style:

Files updated by Task agents:
- app_controller.py: 10 inline imports removed
- demo_data_generator.py: 1 inline import removed
- screens/credential_screens.py: 3 inline imports removed
- screens/duplicates_screen.py: 2 inline imports removed
- keybindings.py: 1 inline import removed

Also updated CLAUDE.md to document the "no inline imports" rule.

Benefits:
- Faster execution (imports at module load, not per call)
- Better code readability
- Dependencies visible at a glance
- Follows Python best practices

All 653 tests pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: wesm

CLAUDE.md

@@ -183,10 +183,14 @@ open htmlcov/index.html
 
 ## Code Style
 
-- Use type hints for all function signatures
-- Document complex logic with comments
-- Keep functions focused and single-purpose
-- Use meaningful variable names
+- **Use type hints** for all function signatures
+- **No inline imports**: All imports must be at the top of the file, not inside functions/methods
+  - Inline imports are slower (import happens on every call)
+  - Harder to see dependencies at a glance
+  - Exception: Circular import issues (rare)
+- **Document complex logic** with comments explaining "why", not "what"
+- **Keep functions focused** - Single responsibility, easy to test
+- **Use meaningful variable names** - Prefer clarity over brevity
 
 ## Making Changes to monarchmoney.py
 

moneyflow/app_controller.py

@@ -18,11 +18,15 @@
 """
 
 from typing import Optional, List
+from datetime import datetime, date as date_type
+import polars as pl
+
 from .view_interface import IViewPresenter
-from .state import AppState, ViewMode, SortMode, SortDirection, TransactionEdit
+from .state import AppState, ViewMode, SortMode, SortDirection, TransactionEdit, TimeFrame
 from .data_manager import DataManager
 from .formatters import ViewPresenter
 from .commit_orchestrator import CommitOrchestrator
+from .time_navigator import TimeNavigator
 from .logging_config import get_logger
 
 logger = get_logger(__name__)
@@ -150,7 +154,6 @@ def refresh_view(self, force_rebuild: bool = True) -> None:
         if filtered_df is not None and not filtered_df.is_empty():
             # Exclude hidden from totals
             non_hidden_df = filtered_df.filter(filtered_df["hideFromReports"] == False)
-            import polars as pl
 
             income_df = non_hidden_df.filter(pl.col("group") == "Income")
             total_income = float(income_df["amount"].sum()) if not income_df.is_empty() else 0.0
@@ -332,22 +335,16 @@ def reverse_sort(self) -> str:
     # Time navigation operations
     def set_timeframe_this_year(self):
         """Set view to current year."""
-        from .state import TimeFrame
-
         self.state.set_timeframe(TimeFrame.THIS_YEAR)
         self.refresh_view()
 
     def set_timeframe_all_time(self):
         """Set view to all time."""
-        from .state import TimeFrame
-
         self.state.set_timeframe(TimeFrame.ALL_TIME)
         self.refresh_view()
 
     def set_timeframe_this_month(self):
         """Set view to current month."""
-        from .state import TimeFrame
-
         self.state.set_timeframe(TimeFrame.THIS_MONTH)
         self.refresh_view()
 
@@ -361,10 +358,6 @@ def select_month(self, month: int) -> str:
         Returns:
             Description of the selected time range
         """
-        from datetime import date as date_type
-        from .time_navigator import TimeNavigator
-        from .state import TimeFrame
-
         today = date_type.today()
         date_range = TimeNavigator.get_month_range(today.year, month)
 
@@ -383,9 +376,6 @@ def navigate_prev_period(self) -> tuple[bool, Optional[str]]:
             - should_fallback_to_year: True if in all-time view (no prev period)
             - description: Time range description if navigated
         """
-        from .time_navigator import TimeNavigator
-        from .state import TimeFrame
-
         if self.state.start_date is None:
             # In all-time view, signal to fallback to current year
             return (True, None)
@@ -406,9 +396,6 @@ def navigate_next_period(self) -> tuple[bool, Optional[str]]:
             - should_fallback_to_year: True if in all-time view (no next period)
             - description: Time range description if navigated
         """
-        from .time_navigator import TimeNavigator
-        from .state import TimeFrame
-
         if self.state.start_date is None:
             # In all-time view, signal to fallback to current year
             return (True, None)
@@ -615,8 +602,6 @@ def queue_category_edits(self, transactions_df, new_category_id: str) -> int:
         Returns:
             int: Number of edits queued
         """
-        from datetime import datetime
-
         count = 0
         for txn in transactions_df.iter_rows(named=True):
             self.data_manager.pending_edits.append(
@@ -645,8 +630,6 @@ def queue_merchant_edits(self, transactions_df, old_merchant: str, new_merchant:
         Returns:
             int: Number of edits queued
         """
-        from datetime import datetime
-
         count = 0
         for txn in transactions_df.iter_rows(named=True):
             self.data_manager.pending_edits.append(
@@ -674,8 +657,6 @@ def queue_hide_toggle_edits(self, transactions_df) -> int:
         Returns:
             int: Number of edits queued
         """
-        from datetime import datetime
-
         count = 0
         for txn in transactions_df.iter_rows(named=True):
             current_hidden = txn.get("hideFromReports", False)

moneyflow/demo_data_generator.py

@@ -10,6 +10,8 @@
 from typing import List, Dict, Any
 import hashlib
 
+from moneyflow.data_manager import CATEGORY_GROUPS
+
 
 class DemoDataGenerator:
     """Generate realistic synthetic financial data."""
@@ -167,9 +169,6 @@ def _create_categories(self) -> List[Dict]:
             "Uncategorized": "grp_uncategorized",
         }
 
-        # Import CATEGORY_GROUPS to get all categories
-        from moneyflow.data_manager import CATEGORY_GROUPS
-
         # Add all categories from CATEGORY_GROUPS that aren't already in base list
         cat_id_counter = 100  # Start at 100 to avoid conflicts with hardcoded IDs
         for group_name, category_list in CATEGORY_GROUPS.items():

moneyflow/keybindings.py

@@ -9,6 +9,8 @@
 from dataclasses import dataclass
 from typing import List
 
+from textual.binding import Binding
+
 
 @dataclass
 class KeyBinding:
@@ -85,8 +87,6 @@ def get_help_text() -> str:
 
 def get_textual_bindings():
     """Get bindings in Textual's Binding format."""
-    from textual.binding import Binding
-
     bindings = []
     for kb in KEYBINDINGS:
         # Only include single-key bindings for Textual

moneyflow/screens/credential_screens.py

@@ -6,6 +6,8 @@
 from textual.containers import Container, Vertical
 from textual.widgets import Button, Input, Label, Static, Checkbox
 
+from ..credentials import CredentialManager
+
 
 class BackendSelectionScreen(Screen):
     """Backend selection screen for first-time setup."""
@@ -239,8 +241,6 @@ async def save_credentials(self) -> None:
 
         # Save credentials
         try:
-            from ..credentials import CredentialManager
-
             error_label.update("💾 Saving credentials...")
             cred_manager = CredentialManager()
             cred_manager.save_credentials(
@@ -376,8 +376,6 @@ async def unlock_credentials(self) -> None:
             return
 
         try:
-            from ..credentials import CredentialManager
-
             error_label.update("🔓 Unlocking...")
             cred_manager = CredentialManager()
             creds = cred_manager.load_credentials(encryption_password=encryption_password)
@@ -397,8 +395,6 @@ async def unlock_credentials(self) -> None:
     async def reset_credentials(self) -> None:
         """Delete credentials and show setup screen."""
         try:
-            from ..credentials import CredentialManager
-
             cred_manager = CredentialManager()
             cred_manager.delete_credentials()
 

moneyflow/screens/duplicates_screen.py

@@ -10,6 +10,9 @@
 from textual.binding import Binding
 import polars as pl
 
+from .transaction_detail_screen import TransactionDetailScreen
+from .edit_screens import DeleteConfirmationScreen
+
 
 class DuplicatesScreen(Screen):
     """Screen to review and handle duplicate transactions."""
@@ -223,8 +226,6 @@ def action_show_details(self) -> None:
         if not txn_data:
             return
 
-        from .transaction_detail_screen import TransactionDetailScreen
-
         self.app.push_screen(TransactionDetailScreen(txn_data))
 
     async def action_delete_transaction(self) -> None:
@@ -239,8 +240,6 @@ async def action_delete_transaction(self) -> None:
             to_delete = [txn_id]
 
         # Show confirmation
-        from .edit_screens import DeleteConfirmationScreen
-
         confirmed = await self.push_screen(
             DeleteConfirmationScreen(transaction_count=len(to_delete)), wait_for_dismiss=True
         )