refactor: Remove unnecessary make_edit helper, consolidate imports

Cleaned up test suite by removing unnecessary indirection:

**1. Removed make_edit helper from conftest.py**
- Was just a thin wrapper around TransactionEdit()
- Tests now use TransactionEdit directly (clearer)
- Eliminated unnecessary factory function layer

**2. Consolidated imports in test_data_manager.py**
- Moved TransactionEdit and datetime imports to top of file
- Removed redundant imports from within test method bodies
- Cleaner, more standard Python test file structure

**3. Fixed indentation issues**
- Corrected indentation after automated replacements
- All test methods properly indented

**Benefits**:
- Less indirection = easier to understand
- Standard import pattern (all at top)
- Cleaner test code for humans to read
- No change in functionality

All 465 tests passing, pyright clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: wesm

moneyflow/state.py

@@ -54,13 +54,18 @@ class TimeFrame(Enum):
 
 @dataclass
 class TransactionEdit:
-    """Represents a pending transaction edit."""
+    """
+    Represents a pending transaction edit.
+
+    Tracks a single change to a transaction (merchant, category, or hide flag)
+    before it's committed to the backend API.
+    """
 
     transaction_id: str
     field: str  # 'merchant', 'category', 'hide_from_reports'
     old_value: Any
     new_value: Any
-    timestamp: datetime = dataclass_field(default_factory=datetime.now)
+    timestamp: datetime = dataclass_field(default_factory=datetime.now)  # When edit was queued
 
 
 @dataclass

tests/conftest.py

@@ -15,46 +15,10 @@
 
 
 # ============================================================================
-# TEST HELPER FUNCTIONS - Eliminate duplication across test suite
+# TEST HELPER FUNCTIONS
 # ============================================================================
 
 
-def make_edit(
-    transaction_id: str,
-    field: str,
-    old_value: any,
-    new_value: any,
-    timestamp: datetime = None
-) -> TransactionEdit:
-    """
-    Create a TransactionEdit for testing.
-
-    Helper to eliminate repeated TransactionEdit(..., datetime.now()) patterns.
-
-    Args:
-        transaction_id: Transaction ID
-        field: Field being edited ('merchant', 'category', 'hide_from_reports')
-        old_value: Original value
-        new_value: New value
-        timestamp: Optional timestamp (defaults to now)
-
-    Returns:
-        TransactionEdit instance
-
-    Example:
-        >>> edit = make_edit("txn1", "merchant", "Old", "New")
-        >>> edit.transaction_id
-        'txn1'
-    """
-    return TransactionEdit(
-        transaction_id=transaction_id,
-        field=field,
-        old_value=old_value,
-        new_value=new_value,
-        timestamp=timestamp or datetime.now()
-    )
-
-
 def save_test_credentials(
     credential_manager,
     email: str = "test@example.com",

tests/test_data_manager.py

@@ -4,7 +4,10 @@
 
 import pytest
 import polars as pl
+from datetime import datetime
+
 from moneyflow.data_manager import DataManager
+from moneyflow.state import TransactionEdit
 
 
 class TestDataFetching:
@@ -147,9 +150,7 @@ class TestCommitEdits:
 
     async def test_commit_single_edit(self, data_manager, mock_mm):
         """Test committing a single edit."""
-        from tests.conftest import make_edit
-
-        edits = [make_edit("txn_1", "merchant", "Old Name", "New Name")]
+        edits = [TransactionEdit("txn_1", "merchant", "Old Name", "New Name", datetime.now())]
 
         success, failure = await data_manager.commit_pending_edits(edits)
 
@@ -164,12 +165,10 @@ async def test_commit_single_edit(self, data_manager, mock_mm):
 
     async def test_commit_multiple_edits(self, data_manager, mock_mm):
         """Test committing multiple edits."""
-        from tests.conftest import make_edit
-
         edits = [
-            make_edit("txn_1", "merchant", "A", "B"),
-            make_edit("txn_2", "category", "cat_old", "cat_new"),
-            make_edit("txn_3", "hide_from_reports", False, True),
+            TransactionEdit("txn_1", "merchant", "A", "B", datetime.now()),
+            TransactionEdit("txn_2", "category", "cat_old", "cat_new", datetime.now()),
+            TransactionEdit("txn_3", "hide_from_reports", False, True, datetime.now()),
         ]
 
         success, failure = await data_manager.commit_pending_edits(edits)
@@ -188,9 +187,7 @@ async def test_commit_empty_edits(self, data_manager, mock_mm):
 
     async def test_commit_merchant_rename(self, data_manager, mock_mm):
         """Test committing a merchant rename."""
-        from tests.conftest import make_edit
-
-        edits = [make_edit("txn_1", "merchant", "Amazon.com", "Amazon")]
+        edits = [TransactionEdit("txn_1", "merchant", "Amazon.com", "Amazon", datetime.now())]
 
         await data_manager.commit_pending_edits(edits)
 
@@ -201,9 +198,7 @@ async def test_commit_merchant_rename(self, data_manager, mock_mm):
 
     async def test_commit_category_change(self, data_manager, mock_mm):
         """Test committing a category change."""
-        from tests.conftest import make_edit
-
-        edits = [make_edit("txn_1", "category", "cat_groceries", "cat_shopping")]
+        edits = [TransactionEdit("txn_1", "category", "cat_groceries", "cat_shopping", datetime.now())]
 
         await data_manager.commit_pending_edits(edits)
 
@@ -214,9 +209,7 @@ async def test_commit_category_change(self, data_manager, mock_mm):
 
     async def test_commit_hide_toggle(self, data_manager, mock_mm):
         """Test committing hide from reports toggle."""
-        from tests.conftest import make_edit
-
-        edits = [make_edit("txn_1", "hide_from_reports", False, True)]
+        edits = [TransactionEdit("txn_1", "hide_from_reports", False, True, datetime.now())]
 
         await data_manager.commit_pending_edits(edits)
 
@@ -508,9 +501,6 @@ async def test_get_stats_with_data(self, loaded_data_manager):
 
     async def test_get_stats_with_pending_edits(self, loaded_data_manager):
         """Test get_stats with pending edits."""
-        from moneyflow.state import TransactionEdit
-        from datetime import datetime
-
         dm, df, _, _ = loaded_data_manager
         dm.df = df
         dm.pending_edits = [
@@ -557,9 +547,6 @@ class TestCommitEditsAdvanced:
 
     async def test_commit_multiple_edits_same_transaction(self, data_manager, mock_mm):
         """Test committing multiple edits to same transaction."""
-        from moneyflow.state import TransactionEdit
-        from datetime import datetime
-
         # Multiple edits to the same transaction should be grouped
         edits = [
             TransactionEdit("txn_1", "merchant", "A", "B", datetime.now()),
@@ -582,9 +569,6 @@ async def test_commit_multiple_edits_same_transaction(self, data_manager, mock_m
 
     async def test_commit_with_api_failure(self, data_manager, mock_mm):
         """Test commit_pending_edits handles API failures gracefully."""
-        from moneyflow.state import TransactionEdit
-        from datetime import datetime
-
         # Create a mock that raises an exception
         original_update = mock_mm.update_transaction
 
@@ -609,9 +593,6 @@ async def failing_update(*args, **kwargs):
 
     async def test_commit_mixed_edit_types(self, data_manager, mock_mm):
         """Test committing different types of edits together."""
-        from moneyflow.state import TransactionEdit
-        from datetime import datetime
-
         edits = [
             TransactionEdit("txn_1", "merchant", "Old", "New", datetime.now()),
             TransactionEdit("txn_2", "category", "cat_1", "cat_2", datetime.now()),