Skip to content

Commit 944bbeb

Browse files
wesmclaude
andcommitted
test: Remove unsupported date tolerance test
Removed skipped test_date_tolerance as date tolerance is not supported in the current groupby-based duplicate detection algorithm and there are no plans to add it. All 654 tests now pass with no skips. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 50226f9 commit 944bbeb

File tree

1 file changed

+0
-48
lines changed

1 file changed

+0
-48
lines changed

tests/test_duplicate_detection.py

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -82,54 +82,6 @@ def test_strict_account_matching(self):
8282
duplicates_loose = DuplicateDetector.find_duplicates(df, strict_account_match=False)
8383
assert len(duplicates_loose) == 1
8484

85-
@pytest.mark.skip(reason="Date tolerance not supported in optimized groupby algorithm")
86-
def test_date_tolerance(self):
87-
"""Test date tolerance for duplicate detection."""
88-
data = [
89-
{
90-
"id": "txn_1",
91-
"date": date(2024, 10, 1),
92-
"amount": -50.00,
93-
"merchant": "Amazon",
94-
"merchant_id": "merch_1",
95-
"category": "Shopping",
96-
"category_id": "cat_1",
97-
"group": "Shopping",
98-
"account": "Chase",
99-
"account_id": "acc_1",
100-
"notes": "",
101-
"hide_from_reports": False,
102-
"pending": False,
103-
"is_recurring": False,
104-
},
105-
{
106-
"id": "txn_2",
107-
"date": date(2024, 10, 2), # One day later
108-
"amount": -50.00,
109-
"merchant": "Amazon",
110-
"merchant_id": "merch_1",
111-
"category": "Shopping",
112-
"category_id": "cat_1",
113-
"group": "Shopping",
114-
"account": "Chase",
115-
"account_id": "acc_1",
116-
"notes": "",
117-
"hide_from_reports": False,
118-
"pending": False,
119-
"is_recurring": False,
120-
},
121-
]
122-
123-
df = pl.DataFrame(data)
124-
125-
# With 0 day tolerance, should NOT be duplicates
126-
duplicates_strict = DuplicateDetector.find_duplicates(df, date_tolerance_days=0)
127-
assert duplicates_strict.is_empty()
128-
129-
# With 1 day tolerance, SHOULD be duplicates
130-
duplicates_tolerant = DuplicateDetector.find_duplicates(df, date_tolerance_days=1)
131-
assert len(duplicates_tolerant) == 1
132-
13385
def test_case_insensitive_merchant_matching(self):
13486
"""Test that merchant matching is case-insensitive."""
13587
data = [

0 commit comments

Comments
 (0)