Skip to content

Commit b85f537

Browse files
committed
The test continues to fail but it is not clear why
1 parent fce4d0b commit b85f537

3 files changed

Lines changed: 26 additions & 13 deletions

File tree

modules/srdfJena/src/main/scala/es/weso/rdf/jena/JenaMapper.scala

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ import es.weso.utils.IOUtils._
2828
import cats.implicits._
2929
import org.apache.jena.graph.Node
3030
import es.weso.rdf.MsgRDFException
31-
import org.apache.jena.vocabulary.RDF.dtRDFHTML
32-
import org.apache.jena.vocabulary.RDF.dtXMLLiteral
3331

3432
object JenaMapper {
3533

@@ -209,6 +207,13 @@ object JenaMapper {
209207
}
210208
}
211209

210+
// I used org.apache.jena.vocabulary.RDF.dtRDFHTML but it seems to fail
211+
lazy val rdfHTML =
212+
new BaseDatatype("http://www.w3.org/1999/02/22-rdf-syntax-ns#HTML")
213+
214+
// I used org.apache.jena.vocabulary.RDF.dtRDFXMLLiteral but it seems to fail
215+
lazy val rdfXML = new BaseDatatype("http://www.w3.org/1999/02/22-rdf-syntax-ns#XML")
216+
212217
def createRDFNode(m: JenaModel, node: RDFNode, base: Option[IRI]): JenaRDFNode = {
213218
val xsd = "http://www.w3.org/2001/XMLSchema#"
214219
val xsdinteger = xsd + "integer"
@@ -224,9 +229,9 @@ object JenaMapper {
224229
case StringLiteral(str) =>
225230
m.createLiteral(str, false)
226231
case RDFHTMLLiteral(str) =>
227-
m.createTypedLiteral(str, dtRDFHTML)
232+
m.createTypedLiteral(str, rdfHTML)
228233
case RDFXMLLiteral(str) =>
229-
m.createTypedLiteral(str, dtXMLLiteral)
234+
m.createTypedLiteral(str, rdfXML)
230235
case DatatypeLiteral(str, i: IRI) =>
231236
i.str match {
232237
case `xsdinteger` => m.createTypedLiteral(str, XSDDatatype.XSDinteger)

modules/srdfJena/src/test/scala/es/weso/rdf/jena/JenaBased.scala

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@ import java.io.ByteArrayInputStream
55
import org.apache.jena.rdf.model.Model
66
import java.io.InputStream
77

8-
98
trait JenaBased {
109

11-
def checkIsomorphic(m1: Model, m2: Model): Either[String,Unit] = {
10+
def checkIsomorphic(m1: Model, m2: Model): Either[String, Unit] = {
1211
val b = m1.isIsomorphicWith(m2)
1312
if (!b) {
1413
Left(s"""|Models are not isomorphic
@@ -17,16 +16,11 @@ trait JenaBased {
1716
} else Right(())
1817
}
1918

20-
/* def shouldBeIsomorphic(m1: Model,m2: Model): Unit = {
21-
checkIsomorphic(m1,m2).fold(fail(_), _ => ())
22-
}*/
23-
24-
2519
def str2model(s: String): Model = {
2620
val m = ModelFactory.createDefaultModel
2721
val in: InputStream = new ByteArrayInputStream(s.getBytes("UTF-8"))
2822
m.read(in, "", "TURTLE")
2923
m
30-
}
24+
}
3125

32-
}
26+
}

modules/srdfJena/src/test/scala/es/weso/rdftriple/jenaMapper/JenaMapperTest.scala

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import es.weso.rdf.triples.RDFTriple
77
import munit._
88
import cats._
99
import cats.implicits._
10+
import scala.jdk.CollectionConverters._
11+
import org.apache.jena.datatypes.RDFDatatype
1012

1113
class JenaMapperTest extends CatsEffectSuite with JenaBased {
1214

@@ -174,6 +176,18 @@ class JenaMapperTest extends CatsEffectSuite with JenaBased {
174176
val empty = ModelFactory.createDefaultModel
175177
val model1 = RDFTriples2Model(ts, empty, None)
176178
val model2 = str2model(s)
179+
val s1 = model1.listSubjects().toList().asScala.head
180+
val s2 = model2.listSubjects().toList().asScala.head
181+
println(s"Subject1 = $s1, ${s1.getClass().getName()}")
182+
println(s"Subject2 = $s2, ${s2.getClass().getName()}")
183+
println(s"Are equal? ${s1.equals(s2)}")
184+
185+
val o1dt = model1.listObjects().toList().asScala.head.asLiteral().getDatatype()
186+
val o2dt = model2.listObjects().toList().asScala.head.asLiteral().getDatatype()
187+
println(s"Object1 = $o1dt, ${o1dt.getClass().getName()}")
188+
println(s"Object2 = $o2dt, ${o2dt.getClass().getName()}")
189+
println(s"Are equal? ${o1dt.equals(o2dt)}")
190+
177191
assertEquals(checkIsomorphic(model1, model2), ().asRight)
178192
}
179193

0 commit comments

Comments
 (0)