Skip to content

Commit 9325e33

Browse files
committed
fix bugs in unit test
1 parent 9530b30 commit 9325e33

3 files changed

Lines changed: 8 additions & 4 deletions

File tree

api/handler/api/feedback_service.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ import (
2121

2222
"github.com/cloudwego/hertz/pkg/app"
2323
"github.com/cloudwego/hertz/pkg/protocol/consts"
24-
"github.com/west2-online/fzuhelper-server/api/model/model"
25-
"github.com/west2-online/fzuhelper-server/pkg/logger"
2624

2725
api "github.com/west2-online/fzuhelper-server/api/model/api"
26+
"github.com/west2-online/fzuhelper-server/api/model/model"
2827
"github.com/west2-online/fzuhelper-server/api/pack"
2928
"github.com/west2-online/fzuhelper-server/api/rpc"
3029
oa "github.com/west2-online/fzuhelper-server/kitex_gen/oa"
3130
"github.com/west2-online/fzuhelper-server/pkg/errno"
31+
"github.com/west2-online/fzuhelper-server/pkg/logger"
3232
)
3333

3434
// CreateFeedback .

api/handler/api/feedback_service_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,11 @@ func TestCreateFeedback(t *testing.T) {
9898
defer mockey.UnPatchAll()
9999
for _, tc := range testCases {
100100
mockey.PatchConvey(tc.name, t, func() {
101-
mockey.Mock(rpc.CreateFeedbackRPC).To(func(ctx context.Context, req *oa.CreateFeedbackRequest) error {
102-
return tc.mockRPCError
101+
mockey.Mock(rpc.CreateFeedbackRPC).To(func(ctx context.Context, req *oa.CreateFeedbackRequest) (int64, error) {
102+
if tc.mockRPCError != nil {
103+
return 0, tc.mockRPCError
104+
}
105+
return 1, nil
103106
}).Build()
104107

105108
result := ut.PerformRequest(router, "POST", tc.url,

internal/oa/service/feedback_service_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222

2323
"github.com/bytedance/mockey"
2424
"github.com/stretchr/testify/assert"
25+
2526
"github.com/west2-online/fzuhelper-server/pkg/base"
2627
"github.com/west2-online/fzuhelper-server/pkg/db"
2728
dbmodel "github.com/west2-online/fzuhelper-server/pkg/db/model"

0 commit comments

Comments
 (0)