feat: make plugin classpath available to Groovy scripts #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for example to access ConfigHelper class. ING-4849
There was a problem hiding this comment.
Pull request overview
This PR enables Groovy scripts executed within the plugin to access the plugin's classpath, specifically allowing access to classes like ConfigHelper. The change updates the GroovyShell initialization to use the plugin's classloader.
- Modified GroovyShell creation to pass the plugin's classloader
- Added mise.toml for Java 17 tooling configuration
- Simplified .wetf-repo.yml by removing redundant workflow preset configuration
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/groovy/to/wetransform/gradle/swarm/actions/assemble/template/GroovyScriptFilter.java | Updated GroovyShell initialization to include the plugin's classloader, enabling script access to plugin classes |
| mise.toml | Added Java 17 tooling specification using Temurin distribution |
| .wetf-repo.yml | Removed redundant java-17 workflow preset configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for example to access ConfigHelper class.
ING-4849