Copy terminfo into MacOS app resources #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the terminfo file has to be downloaded from the repo and installed manually. It'd be nice to include it in the app so that a package manager like Homebrew could install it in the right place when Wezterm is installed, which is something that Alacritty does. I've chosen to include the compiled version so that package manager don't have to invoke `tic` and can just copy files around. This will result in the following being added to the Resources folder: ``` WezTerm.app/Contents/Resources/terminfo/77/wezterm ``` Once this is in I'll send a patch to update the [Homebrew formula](https://github.com/Homebrew/homebrew-cask/blob/master/Casks/w/wezterm.rb) and have it actually install the terminfo.
ddeville
added a commit
to ddeville/homebrew-cask
that referenced
this pull request
Jan 2, 2025
The compiled terminfo entry was added to the app bundle (see wezterm/wezterm#6538) so install it in `~/.terminfo`.
ddeville
added a commit
to ddeville/homebrew-cask
that referenced
this pull request
Jan 2, 2025
The compiled terminfo entry was added to the app bundle (see wezterm/wezterm#6538) so install it in `~/.terminfo` on behalf of the user.
|
Thanks! |
|
Note that the CI is currently borked due to the move to an org, I expect that it will unbork itself in a couple of days; until then, the homebrew side of this will likely need to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the terminfo file has to be downloaded from the repo and installed manually. It'd be nice to include it in the app so that a package manager like Homebrew could install it in the right place when Wezterm is installed, which is something that Alacritty does.
I've chosen to include the compiled version so that package manager don't have to invoke
ticand can just copy files around.This will result in the following being added to the Resources folder:
Once this is in I'll send a patch to update the Homebrew formula and have it actually install the terminfo.