width and height attribute on source element whose parent is a media element

[mtrootyy]

https://html.spec.whatwg.org/multipage/embedded-content.html#the-source-element:attr-source-srcset-4

The srcset, sizes, and media attributes must not be present.

　　 ↓
width and height attribute should be also added.

[domenic]

Good catch. I think it'd also be good to move that restriction up above the example so it's harder to miss.

Would you like to submit a pull request fixing this?

[mtrootyy]

Sorry, I have no experience with pull request, so I want someone to do it.
Fixing this might as well be added to #6419.

[annevk]

@zcorpan ^

[zcorpan]

Thanks @mtrootyy! I think this should be fixed separately from #6419 since this is a normative bug fix.

If you're interested in trying out creating a pull request in the future, maybe this documentation can help:

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/proposing-changes-to-your-work-with-pull-requests

Alternatively, the documentation for the web-platform-tests project has a good introduction to the steps for making a pull request:

https://web-platform-tests.org/writing-tests/github-intro.html

There's one more hurdle here though: for pull requests to be accepted, you or your employer will need to sign the participation agreement: https://participate.whatwg.org/agreement

[satrujit11]

hey.. I am a beginner. I want to fix this issue. Can you guide me on where to add width and height attribute?

[zcorpan]

@satrujit11 in the paragraph quoted in the OP (original post) above. On the current main branch it's at line 26232 in the source file.

[satrujit11]

@satrujit11 in the paragraph quoted in the OP (original post) above. On the current main branch it's at line 26232 in the source file.

how much height and width should I add?