Closed as duplicate
Description
Firstly, my apologies if this is the wrong place to report this. I couldn't figure out what repo the build bot lives in.
When a spec PR includes changes to an IDL definition, the diff preview gets confused. For example, a recent DOM PR modified the Document
IDL definition, which in the diff viewer shows up like this:
and then at the bottom of the IDL section, this:
The actual diff was:
-[CEReactions, NewObject] Node importNode(Node node, optional boolean subtree = false);
+[CEReactions, NewObject] Node importNode(Node node, optional (boolean or ImportNodeOptions) options = false);
My guess is that the syntax-highlighting markup clashes with the diff-viewer markup. In any case, as someone who makes use of the diff viewer to find what's changed, it'd be helpful if IDL changes showed up correctly. I managed to miss a few in a recent spec change because of this. 😅
Metadata
Metadata
Assignees
Labels
No labels