Skip to content

Commit 07be486

Browse files
bpamiriclaude
andcommitted
fix(ci): remove reload=true — not needed and breaks Adobe CF
The ?db= parameter switches application.wheels.dataSourceName directly (runner.cfm:70-80). No reload needed because: - $_setTestboxEnv() handles datasource switching per HTTP request - populate.cfm creates identical table schemas across all databases - The old 42-job workflow never used reload=true either reload=true was breaking Adobe CF engines because $handleRestartAppRequest passes "application" as a component reference to cfinvoke, which Adobe CF can't resolve. Removing it fixes all Adobe engines and simplifies the curl. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 466eb25 commit 07be486

File tree

1 file changed

+8
-15
lines changed

1 file changed

+8
-15
lines changed

.github/workflows/tests.yml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -222,12 +222,12 @@ jobs:
222222
echo "Running tests: ${{ matrix.cfengine }} + ${db}"
223223
echo "=============================================="
224224
225-
# reload=true clears model cache for clean DB switch. Wheels strips
226-
# reload/password from the URL and 302s (redirectAfterReload setting),
227-
# preserving db= and format=. Using -L follows the redirect, so a single
228-
# request both reloads AND runs tests — no double execution.
229-
TEST_URL="${BASE_URL}?db=${db}&reload=true&format=json"
230-
RETRY_URL="${BASE_URL}?db=${db}&format=json"
225+
# The ?db= parameter switches application.wheels.dataSourceName
226+
# (runner.cfm:70-80). No reload needed — runner.cfm's $_setTestboxEnv()
227+
# handles datasource switching per request, and populate.cfm ensures
228+
# identical table schemas across all databases. The old workflow never
229+
# used reload=true either.
230+
TEST_URL="${BASE_URL}?db=${db}&format=json"
231231
232232
RESULT_FILE="/tmp/test-results/${{ matrix.cfengine }}-${db}-result.txt"
233233
JUNIT_FILE="/tmp/junit-results/${{ matrix.cfengine }}-${db}-junit.xml"
@@ -240,17 +240,10 @@ jobs:
240240
RETRY_COUNT=$((RETRY_COUNT + 1))
241241
echo "Test attempt ${RETRY_COUNT} of ${MAX_RETRIES}..."
242242
243-
# First attempt includes reload=true; retries skip reload
244-
if [ "$RETRY_COUNT" -eq 1 ]; then
245-
CURL_URL="$TEST_URL"
246-
else
247-
CURL_URL="$RETRY_URL"
248-
fi
249-
250-
HTTP_CODE=$(curl -s -L -o "$RESULT_FILE" \
243+
HTTP_CODE=$(curl -s -o "$RESULT_FILE" \
251244
--max-time 900 \
252245
--write-out "%{http_code}" \
253-
"$CURL_URL" || echo "000")
246+
"$TEST_URL" || echo "000")
254247
255248
echo "HTTP Code: ${HTTP_CODE}"
256249

0 commit comments

Comments
 (0)