Commit 1a1241c
fix(cli): repoint 15 dead v4-0-0-snapshot and 3.1.0 guide URLs at live v4 pages (#3281)
* fix(cli): repoint 15 dead v4-0-0-snapshot and 3.1.0 guide URLs at live v4 pages
The pre-GA v4-0-0-snapshot docs slug was retired at GA, killing every
templated guide URL still carrying it — including working-with-wheels/*
paths that only ever existed in the v3 tree. Freshly scaffolded apps
shipped comments and READMEs linking 404s, and two runtime CLI messages
(Module.cfc install pointer, Doctor.cfc remediation) printed dead links.
Repointed at live guides.wheels.dev/v4-0-0/ pages (every target
curl-verified 200 before the swap):
- scaffold config/settings.cfm + environment.cfm ->
core-concepts/environments-and-configuration/
- scaffold config/routes.cfm + both ConfigRoutes.txt templates ->
basics/routing/
- mailers/jobs/plugins template READMEs -> digging-deeper/sending-email/,
background-jobs/, packages/ (also fixes the bare wheels.dev domain that
should be guides.wheels.dev)
- Module.cfc + Doctor.cfc runtime messages -> start-here/installing/
- cli/README.md -> command-line-tools/
- cli/src analyze/code.cfc report footer (wheels.dev/3.1.0 era) ->
command-line-tools/wheels-commands/code-quality/
- demo app config/settings.cfm + environment.cfm (wheels.dev/3.1.0 era) ->
core-concepts/environments-and-configuration/
ConfigRoutesStaleDocUrlSpec updated: its 'canonical' routing URL was
itself the dead snapshot slug; now pins basics/routing/ and gains a
structural guard that scans cli/lucli/templates/ plus the known
runtime-message files for any reintroduction of retired URL shapes
(v4-0-0-snapshot, wheels.dev/3.1.0, cfwheels.org-era hosts).
Verified: wheels.tests.specs.cli suite passes locally on Lucee 7 + SQLite
(127 specs) including the rewritten guard.
Signed-off-by: Peter Amiri <petera@pai.com>
* ci: install git before checkout in the CommandBox smoke container
The commandbox-install-smoke job has failed with exit 127 on every run
since it was added: the ortussolutions/commandbox image ships without
git, so actions/checkout falls back to the REST-API tarball — which
honors .gitattributes export-ignore, and this repo export-ignores
tools/ and cli/. The workspace therefore never contained the build
scripts and templates the job exists to test.
Install git before checkout so it performs a real clone, and assert
post-checkout that tools/build/scripts/prepare-base.sh is present so
any future fallback is named precisely instead of failing as a
missing-file error three steps later.
Signed-off-by: Peter Amiri <petera@pai.com>
* fix: repoint the demo app routes.cfm guide URL and cover it in the guard
Addresses the wheels-bot review finding: config/routes.cfm:4 still
shipped a retired wheels.dev/3.1.0 URL — the one file its two
same-directory siblings' fix missed — and the new structural guard's
extraFiles list didn't cover it, so the guard passed green while a dead
link shipped. Repointed to guides.wheels.dev/v4-0-0/basics/routing/
(matching the scaffold template) and added config/routes.cfm to the
guard's extraFiles. Also adds the changelog fragment the review noted
was missing for this user-facing fix.
Signed-off-by: Peter Amiri <petera@pai.com>
---------
Signed-off-by: Peter Amiri <petera@pai.com>
Co-authored-by: Peter Amiri <petera@pai.com>1 parent 334a719 commit 1a1241c
18 files changed
Lines changed: 107 additions & 40 deletions
File tree
- .github/workflows
- changelog.d
- cli
- lucli
- services
- templates/app
- app
- jobs
- mailers
- plugins
- snippets
- config
- src
- commands/wheels/analyze
- templates
- config
- vendor/wheels/tests/specs/cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
83 | 97 | | |
84 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
85 | 104 | | |
86 | 105 | | |
87 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6429 | 6429 | | |
6430 | 6430 | | |
6431 | 6431 | | |
6432 | | - | |
| 6432 | + | |
6433 | 6433 | | |
6434 | 6434 | | |
6435 | 6435 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
660 | 660 | | |
661 | 661 | | |
662 | 662 | | |
663 | | - | |
| 663 | + | |
664 | 664 | | |
665 | 665 | | |
666 | 666 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
| 51 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
0 commit comments