Commit 21c32a8
committed
fix(view): address Reviewer A/B consensus findings (round 4)
Forward `windowSize` to `pageNumberLinks()` on the `paginationNav()`
viewStyle path so the auto-mode predicate and the rendered window
are evaluated against the same value.
- `vendor/wheels/view/pagination.cfc`: add `numeric windowSize` to
`$renderPaginationNav()` signature, pass `windowSize` at the
call site, and copy it into `local.pageArgs` before invoking
`pageNumberLinks()`.
- `vendor/wheels/tests/specs/view/paginationHelpersSpec.cfc`: add a
regression-guard spec under "paginationNav with viewStyle presets"
asserting that `paginationNav(viewStyle="bootstrap5", windowSize=4)`
with `currentPage=5, totalRecords=100, perPage=10` includes page 8
in the output.
Signed-off-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>1 parent 0c79f86 commit 21c32a8
2 files changed
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
369 | 369 | | |
370 | 370 | | |
371 | 371 | | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
372 | 384 | | |
373 | 385 | | |
374 | 386 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
511 | 511 | | |
512 | 512 | | |
513 | 513 | | |
| 514 | + | |
514 | 515 | | |
515 | 516 | | |
516 | 517 | | |
| |||
819 | 820 | | |
820 | 821 | | |
821 | 822 | | |
| 823 | + | |
822 | 824 | | |
823 | 825 | | |
824 | 826 | | |
| |||
845 | 847 | | |
846 | 848 | | |
847 | 849 | | |
| 850 | + | |
| 851 | + | |
848 | 852 | | |
849 | 853 | | |
| 854 | + | |
850 | 855 | | |
851 | 856 | | |
852 | 857 | | |
| |||
0 commit comments