Commit 27fddae
style(model): condense review-flagged inline comments (#2852)
Address Reviewer A's comment-length nits: collapse the 8-line block in Model.cfc and the multi-line blocks in propertyCasePreservationSpec to single lines (CLAUDE.md one-line-comment guidance). Base.$lowerCaseColumnNames() keeps its docstring — it matches the existing $supportsAdvisoryLocks() convention, which both reviewers endorsed. The spec's adapter-name list is kept (deriving it from $lowerCaseColumnNames() needs a public model->adapter accessor that doesn't exist — getClass() isn't a model method and there is no $getAdapter()); reviewers flagged this as a non-blocking maintenance note.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Peter Amiri <peter@alurium.com>1 parent 12eccdb commit 27fddae
2 files changed
Lines changed: 5 additions & 33 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
| 128 | + | |
136 | 129 | | |
137 | 130 | | |
138 | 131 | | |
| |||
Lines changed: 4 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | 8 | | |
| 9 | + | |
28 | 10 | | |
29 | 11 | | |
30 | | - | |
31 | | - | |
32 | | - | |
| 12 | + | |
33 | 13 | | |
34 | 14 | | |
35 | 15 | | |
36 | | - | |
37 | | - | |
| 16 | + | |
38 | 17 | | |
39 | 18 | | |
40 | 19 | | |
| |||
0 commit comments