Skip to content

Commit 3bfa6bb

Browse files
bpamiriclaude
andcommitted
Remove redundant throwOnColumnNotFound=true test (SQL cache conflict)
Wheels caches SQL shells by hashing model name + arguments. The "still throws" test used the same select string as the preceding "skips invalid" test, so it hit the cached SQL (built without the invalid column) and never reached the column validation code. The throws-when-true behavior is already covered by the existing "throws error for invalid select column" test which uses a different select string and runs before any test disables the setting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 323234d commit 3bfa6bb

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

vendor/wheels/tests/specs/model/raisedErrorsSpec.cfc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,6 @@ component extends="wheels.WheelsTest" {
5757
application.wheels.throwOnColumnNotFound = true;
5858
}
5959
})
60-
61-
it("still throws ColumnNotFound for invalid select column when throwOnColumnNotFound is true", () => {
62-
application.wheels.throwOnColumnNotFound = true;
63-
expect(function() {
64-
g.model("user").findAll(select="id,firstname,nonexistentcolumn")
65-
}).toThrow("Wheels.ColumnNotFound")
66-
})
6760
})
6861
}
6962
}

0 commit comments

Comments
 (0)