fix(cli): split comma-joined action tokens in generate controller (#3131)

* fix(cli): split comma-joined action tokens in generate controller

`wheels generate controller Name a,b` passed the comma-joined token through
verbatim, emitting an invalid `function a,b()` method plus an `a,b.cfm` view
file. Normalize the action list in CodeGen.generateController by splitting each
positional token on commas, trimming, and de-duplicating, and return the
normalized list so Module.cfc renders one view file per real action. The comma
form now behaves identically to the documented space-separated form.

Fixes #3112

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>

* docs(web/guides): note comma-separated action form in generate controller

Signed-off-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>

* fix(cli): keep generate controller no-actions path from writing an index view

Review finding on #3131: the unconditional `actions = result.actions` in
Module.cfc adopted CodeGen's defaulted ["index"] list when the user passed no
actions, so `wheels generate controller Users` started writing
app/views/users/index.cfm — contradicting the documented "passing no actions
creates an empty controller with no view files" behavior retained in the same
code-generation.mdx paragraph.

Surface the caller-requested (post-normalization, pre-default) action list as
result.actions instead: empty input stays empty, so the view loop writes
nothing, while comma-joined tokens still expand to one view per real action.
The controller body keeps its default index() stub as before. Covered by a new
CodeGenSpec case asserting result.actions is empty (and the stub present) for
the no-actions path.

Signed-off-by: Peter Amiri <peter@alurium.com>

---------

Signed-off-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Signed-off-by: Peter Amiri <peter@alurium.com>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Peter Amiri <peter@alurium.com>

Author: 4 people

changelog.d/3112-generate-controller-comma-actions.fixed.md

@@ -0,0 +1 @@
+- `wheels generate controller Name a,b` now splits the comma-joined action token into discrete actions (`a` and `b`) instead of silently emitting an invalid `function a,b()` method plus an `a,b.cfm` view file — the comma form now matches the documented space-separated form (#3112)

cli/lucli/Module.cfc

@@ -3253,6 +3253,13 @@ component extends="modules.BaseModule" {
 			return "";
 		}
 
+		// Use the normalized action list from the generator (comma-joined tokens like
+		// "index,show" are split into discrete actions) so view files match the
+		// controller methods instead of being named "index,show.cfm" (#3112). When no
+		// actions were passed result.actions is empty — documented behavior is an
+		// empty controller with no view files, so the view loop below writes nothing.
+		actions = result.actions;
+
 		// Create view files for non-mutation actions
 		var viewDir = variables.projectRoot & "/app/views/#lCase(controllerName)#";
 		ensureDirectory(viewDir);

cli/lucli/services/CodeGen.cfc

@@ -142,6 +142,19 @@ component {
 
 		var crudActions = ["index", "show", "new", "create", "edit", "update", "delete"];
 
+		// Normalize the action list: a comma-joined token like "index,show" is the
+		// natural guess for anyone used to Wheels list args (validatesPresenceOf("a,b")),
+		// but passed through verbatim it produced `function index,show()` — invalid CFML
+		// that fails to compile — plus a view file named `index,show.cfm` (#3112). Split
+		// each token on commas, trim, and de-duplicate so both forms behave identically.
+		arguments.actions = normalizeActions(arguments.actions);
+
+		// Capture the caller-requested list BEFORE the defaulting below. result.actions
+		// drives the caller's view loop, and the documented contract is "passing no
+		// actions creates an empty controller with no view files" — the index/CRUD
+		// defaults applied next shape the controller body only, never the view files.
+		var requestedActions = arguments.actions;
+
 		// Default actions based on type
 		if (arrayLen(arguments.actions) == 0) {
 			arguments.actions = arguments.crud ? crudActions : ["index"];
@@ -171,11 +184,38 @@ component {
 			template = hasCustomActions ? "ControllerContent.txt" : "CRUDContent.txt";
 		}
 
-		return variables.templateService.generateFromTemplate(
+		var result = variables.templateService.generateFromTemplate(
 			template = template,
 			destination = relativePath,
 			context = context
 		);
+
+		// Surface the normalized caller-requested action list so callers (e.g.
+		// Module.cfc's view loop) render one view file per real action instead of one
+		// named after the raw comma-joined token (#3112). Deliberately the pre-default
+		// list: when no actions were passed this stays empty, so callers write no view
+		// files even though the controller body gets a default index() stub.
+		result.actions = requestedActions;
+		return result;
+	}
+
+	/**
+	 * Flatten a positional action list into discrete, trimmed, de-duplicated action
+	 * names. Splits comma-joined tokens ("index,show" -> ["index","show"]) so the comma
+	 * form matches the documented space-separated form, drops empties, and preserves
+	 * first-seen order. Comparison is case-insensitive but the original casing is kept (#3112).
+	 */
+	private array function normalizeActions(required array actions) {
+		var normalized = [];
+		for (var token in arguments.actions) {
+			for (var part in listToArray(token, ",")) {
+				var trimmed = trim(part);
+				if (len(trimmed) && !arrayFindNoCase(normalized, trimmed)) {
+					arrayAppend(normalized, trimmed);
+				}
+			}
+		}
+		return normalized;
 	}
 
 	/**

cli/lucli/tests/specs/services/CodeGenSpec.cfc

@@ -219,6 +219,52 @@ component extends="wheels.wheelstest.system.BaseSpec" {
 					expect(content).toInclude('extends="Controller"');
 				});
 
+				it("splits a comma-joined action token into separate actions (##3112)", () => {
+					var result = codegen.generateController(
+						name = "Authors",
+						actions = ["index,show"],
+						force = true
+					);
+					var content = fileRead(tempRoot & "/app/controllers/Authors.cfc");
+					// The bug: one element "index,show" emitted as `function index,show()`
+					expect(content).notToInclude("index,show");
+					expect(content).toInclude("function index()");
+					expect(content).toInclude("function show()");
+				});
+
+				it("returns the normalized action list so callers render correct views (##3112)", () => {
+					var result = codegen.generateController(
+						name = "Editors",
+						actions = ["index, show ,create"],
+						force = true
+					);
+					expect(result.actions).toBe(["index", "show", "create"]);
+				});
+
+				it("de-duplicates and trims actions from comma tokens (##3112)", () => {
+					var result = codegen.generateController(
+						name = "Curators",
+						actions = ["index", "show,index"],
+						force = true
+					);
+					expect(result.actions).toBe(["index", "show"]);
+				});
+
+				it("returns an empty action list when no actions are passed so callers write no views", () => {
+					var result = codegen.generateController(
+						name = "Stubs",
+						actions = [],
+						force = true
+					);
+					var content = fileRead(tempRoot & "/app/controllers/Stubs.cfc");
+					// The controller body still gets the default index() stub...
+					expect(content).toInclude("function index()");
+					// ...but result.actions stays empty so the caller writes no view
+					// files, preserving the documented "no actions => empty controller
+					// with no view files" behavior (PR ##3131 review).
+					expect(result.actions).toBeEmpty();
+				});
+
 			});
 
 			describe("validateName()", () => {

web/sites/guides/src/content/docs/v4-0-0/command-line-tools/wheels-commands/code-generation.mdx

@@ -106,7 +106,7 @@ wheels generate controller <Name> [action ...]
 
 #### Description
 
-Writes `app/controllers/<Name>.cfc` with a stub method per action name you pass. For each action that isn't `create`, `update`, `delete`, or `destroy`, the generator also writes `app/views/<name>/<action>.cfm`. Passing no actions creates an empty controller with no view files.
+Writes `app/controllers/<Name>.cfc` with a stub method per action name you pass. For each action that isn't `create`, `update`, `delete`, or `destroy`, the generator also writes `app/views/<name>/<action>.cfm`. Passing no actions creates an empty controller with no view files. Action names may be space-separated or comma-separated — `index,show` is equivalent to `index show`.
 
 #### Example