Skip to content

Commit f668c50

Browse files
bpamiriclaude
andauthored
ci: point docs-verify at the live v4-0-0 tree, untag illustrative blocks (#3043)
* ci: point docs-verify at the live v4-0-0 tree, untag illustrative blocks The workflow's path triggers still referenced v4-0-0-snapshot/**, deleted at the GA rename (4a62207) — live-tree doc edits could never fire the verify job. Point both path filters at the live tree and its sidebar. The verify step keeps continue-on-error: true until issue #3041 (the compile driver needs a framework-context fixture path; 312 live blocks currently fail on missing context, not content) — this change buys advisory visibility, not gating. Also remove {test:compile} from the six blocks titled illustrative (coding-standards.mdx x5, authentication-patterns.mdx x1) per the tagging policy in writing-docs.mdx: anything that cannot compile gets the illustrative title INSTEAD of a test tag. Refs #3041 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com> * ci: trust the wheels tap before install — Homebrew 5.1+ gates third-party formulae The workflow's dormancy hid this second rot layer: while the trigger paths pointed at the deleted snapshot tree, Homebrew shipped formula trust gating, so the first re-armed run failed at brew install with 'Refusing to load formula ... from untrusted tap'. brew trust is a no-op guarded with || true on older brew versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com> * ci: disable Homebrew Linux sandbox on the runner — no rootless bwrap available Dormancy rot layer three: Homebrew 5.x's Linux sandbox requires Bubblewrap, absent on ubuntu-latest (and unreliable there even when installed, given 24.04's unprivileged-userns restrictions). The ephemeral CI runner is already isolation enough; HOMEBREW_NO_SANDBOX_LINUX is the documented opt-out. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com> --------- Signed-off-by: Peter Amiri <peter@alurium.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
1 parent ba57f85 commit f668c50

3 files changed

Lines changed: 17 additions & 8 deletions

File tree

.github/workflows/docs-verify.yml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ on:
44
pull_request:
55
branches: [develop]
66
paths:
7-
- 'web/sites/guides/src/content/docs/v4-0-0-snapshot/**'
7+
- 'web/sites/guides/src/content/docs/v4-0-0/**'
88
- 'web/sites/guides/scripts/verify-docs/**'
99
- 'web/sites/guides/package.json'
10-
- 'web/sites/guides/src/sidebars/v4-0-0-snapshot.json'
10+
- 'web/sites/guides/src/sidebars/v4-0-0.json'
1111
- '.github/workflows/docs-verify.yml'
1212

1313
jobs:
@@ -45,8 +45,17 @@ jobs:
4545
uses: Homebrew/actions/setup-homebrew@master
4646

4747
- name: Install Wheels CLI
48+
env:
49+
# Homebrew 5.x's Linux sandbox needs a rootless bwrap, which
50+
# ubuntu-latest runners don't provide (and 24.04's unprivileged
51+
# userns restrictions make it unreliable even when installed).
52+
# The ephemeral runner is already isolation enough for CI.
53+
HOMEBREW_NO_SANDBOX_LINUX: "1"
4854
run: |
4955
brew tap wheels-dev/wheels || true
56+
# Homebrew 5.1+ refuses to load formulae from untrusted third-party
57+
# taps; trust must be granted explicitly (no-op on older brew).
58+
brew trust wheels-dev/wheels || true
5059
brew install wheels
5160
5261
- name: Patch wheels wrapper JAVA_HOME for Linux

web/sites/guides/src/content/docs/v4-0-0/contributing/coding-standards.mdx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ These come directly from `.ai/wheels/cross-engine-compatibility.md` and are the
7878

7979
Both engines resolve `obj.map()` as the built-in struct member function, not your CFC's `map()` method. The DI container exposes `mapInstance()` as the engine-safe alias.
8080

81-
```cfm title="illustrative — do not type" {test:compile}
81+
```cfm title="illustrative — do not type"
8282
// WRONG — triggers struct.map(callback) on Lucee/Adobe
8383
arguments.container.map("myService").to("path").asSingleton();
8484
@@ -90,7 +90,7 @@ arguments.container.mapInstance("myService").to("path").asSingleton();
9090

9191
Adobe's `application` scope is Java-backed and loses function members across requests. Pass a plain struct context instead of mutating `application` directly.
9292

93-
```cfm title="illustrative — do not type" {test:compile}
93+
```cfm title="illustrative — do not type"
9494
// WRONG — works on Lucee, breaks on Adobe
9595
application.registerMiddleware = function() { return true; };
9696
@@ -103,7 +103,7 @@ context.registerMiddleware = function() { return true; };
103103

104104
A closure binds `this` to where it is defined, not where it is assigned. Test code that dynamically attaches methods to a controller will call back into the spec, not the controller.
105105

106-
```cfm title="illustrative — do not type" {test:compile}
106+
```cfm title="illustrative — do not type"
107107
// WRONG — this.renderText() runs on the test spec
108108
_controller.myAction = function() {
109109
this.renderText("hello");
@@ -120,7 +120,7 @@ _controller.myAction = function() {
120120

121121
Split the lookup and the call.
122122

123-
```cfm title="illustrative — do not type" {test:compile}
123+
```cfm title="illustrative — do not type"
124124
// WRONG — crashes Adobe CF 2021/2023 parser inside closures
125125
var result = obj["dynamicMethod"]();
126126
@@ -133,7 +133,7 @@ var result = fn();
133133

134134
`{arr: myArray}` duplicates the array on Adobe. Closures that append to the copy never touch the original. Reference through a parent struct.
135135

136-
```cfm title="illustrative — do not type" {test:compile}
136+
```cfm title="illustrative — do not type"
137137
// WRONG — Adobe copies myArray into the struct
138138
var config = {arr: myArray};
139139

web/sites/guides/src/content/docs/v4-0-0/digging-deeper/authentication-patterns.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ The callback receives the extracted token string and returns a principal struct
209209

210210
### Static token map (tests, seeded keys)
211211

212-
```cfm {test:compile} title="illustrative — static tokens"
212+
```cfm title="illustrative — static tokens"
213213
var tokenStrategy = new wheels.auth.TokenStrategy(tokens={
214214
"dev-key-alice": {id: 1, role: "admin"},
215215
"dev-key-bob": {id: 2, role: "reader"}

0 commit comments

Comments
 (0)