Use strict types

Author: whikloj

src/AbstractManifest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools;
 
 use Normalizer;

src/Bag.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools;
 
 use Archive_Tar;

src/BagUtils.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools;
 
 use TypeError;
@@ -413,7 +415,7 @@ public static function encodeFilepath(string $line): string
      */
     public static function checkUnencodedFilepath(string $filepath): bool
     {
-        return preg_match_all("/%(?!(25|0A|0D))/", $filepath);
+        return (bool) preg_match_all("/%(?!(25|0A|0D))/", $filepath);
     }
 
     /**

src/Commands/ValidateCommand.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Commands;
 
 use Symfony\Component\Console\Command\Command;

src/Exceptions/BagItException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Exceptions;
 
 use Exception;

src/Exceptions/FilesystemException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Exceptions;
 
 /**

src/Fetch.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools;
 
 use Normalizer;

src/PayloadManifest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools;
 
 /**
@@ -11,16 +13,18 @@
  */
 class PayloadManifest extends AbstractManifest
 {
-  /**
-   * PayloadManifest constructor.
-   *
-   * @param \whikloj\BagItTools\Bag $bag
-   *   The bag this manifest is part of.
-   * @param string $algorithm
-   *   The BagIt name of the hash algorithm.
-   * @param bool $load
-   *   Whether we are loading an existing file
-   */
+    /**
+     * PayloadManifest constructor.
+     *
+     * @param \whikloj\BagItTools\Bag $bag
+     *   The bag this manifest is part of.
+     * @param string $algorithm
+     *   The BagIt name of the hash algorithm.
+     * @param bool $load
+     *   Whether we are loading an existing file
+     * @throws \whikloj\BagItTools\Exceptions\FilesystemException
+     *   Unable to read manifest file.
+     */
     public function __construct(Bag $bag, string $algorithm, bool $load = false)
     {
         parent::__construct($bag, $algorithm, "manifest-$algorithm.txt", $load);

src/TagManifest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools;
 
 /**
@@ -11,16 +13,18 @@
  */
 class TagManifest extends AbstractManifest
 {
-  /**
-   * PayloadManifest constructor.
-   *
-   * @param \whikloj\BagItTools\Bag $bag
-   *   The bag this manifest is part of.
-   * @param string $algorithm
-   *   The BagIt name of the hash algorithm.
-   * @param boolean $load
-   *   Whether we are loading an existing file
-   */
+    /**
+     * PayloadManifest constructor.
+     *
+     * @param \whikloj\BagItTools\Bag $bag
+     *   The bag this manifest is part of.
+     * @param string $algorithm
+     *   The BagIt name of the hash algorithm.
+     * @param boolean $load
+     *   Whether we are loading an existing file
+     * @throws \whikloj\BagItTools\Exceptions\FilesystemException
+     *   Unable to read manifest file.
+     */
     public function __construct(Bag $bag, string $algorithm, bool $load = false)
     {
         parent::__construct($bag, $algorithm, "tagmanifest-$algorithm.txt", $load);

tests/BagInternalTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use ReflectionClass;

tests/BagItTestFramework.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use PHPUnit\Framework\TestCase;

tests/BagTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use whikloj\BagItTools\Bag;
@@ -823,7 +825,7 @@ public function testUpdateV07(): void
         $this->assertTrue($bag->validate());
         $fp = fopen($bag->getBagRoot() . DIRECTORY_SEPARATOR . 'bag-info.txt', 'r');
         while (!feof($fp)) {
-            $line = fgets($fp);
+            $line = (string) fgets($fp);
             $line = trim($line);
             if (empty($line)) {
                 continue;
@@ -837,7 +839,7 @@ public function testUpdateV07(): void
         $this->assertTrue($bag->validate());
         $fp = fopen($bag->getBagRoot() . DIRECTORY_SEPARATOR . 'bag-info.txt', 'r');
         while (!feof($fp)) {
-            $line = fgets($fp);
+            $line = (string) fgets($fp);
             $line = trim($line);
             if (empty($line)) {
                 continue;

tests/BagUtilsTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use Exception;

tests/CommandTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use Symfony\Component\Console\Application;

tests/ExtendedBagTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use whikloj\BagItTools\Bag;

tests/FetchTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use donatj\MockWebServer\MockWebServer;

tests/ManifestTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace whikloj\BagItTools\Test;
 
 use whikloj\BagItTools\Bag;