Open
Description
Summary:
Lines 97–99 in pyani/fastani.py
:
if fastani_path is None:
return f"{fastani_exe} is not found in $PATH"
are missed by testing, and likely redundant. fastani_path
is defined a few lines before, within a try/except
block; were this to raise something other than a TypeError
(thus leaving fastani_path
unassigned), which is handled with a logging statement, the program would still exit before lines 97–99 were run.
Commenting out these lines causes no tests to fail. Whereas commenting out lines 93–96, causes test_get_version_nonetype()
from pyani/tests/test_fastani.py
to fail.
pyani Version:
pyani version: 0.3.0-alpha
installed dependencies
If you are running a version of pyani
v0.3 or later, then please run the command pyani listdeps
at the command line, and enter the output below.
Python Version:
3.8.12
Operating System:
macOS High Sierra