Merge branch 'main' into feature/drupal-10

Author: akasake

CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.9.5] - 2022-1-11
+### Fixed
+- Validate access on each submitted entity for bulk action
+
+## [1.9.4] - 2021-12-16
+### Fixed
+- Fix PHP 8.1 warnings
+
 ## [1.9.3] - 2021-12-08
 ### Fixed
 - Fix weight not persisting when using DraggableOverviewBuilderBase

css/filter-form.css

@@ -23,13 +23,18 @@
     margin-left: 0.5rem;
 }
 
-.wmentity-overview-filter-form__actions {
-    margin-left: .5rem; /* LTR */
+.wmentity-overview-filter-form .form-item:last-child {
+    /* LTR */
+    margin-right: 1rem;
 }
 
-[dir="rtl"] .wmentity-overview-filter-form__actions {
-    margin-left: 0;
-    margin-right: .5rem;
+[dir="rtl"] .wmentity-overview-filter-form .form-item:last-child {
+    margin-right: 0;
+    margin-left: 1rem;
+}
+
+.wmentity-overview-filter-form .form-item .claro-autocomplete {
+    width: auto;
 }
 
 .wmentity-overview-filter-form__actions .button {

src/FilterStorage/FilterStorageBase.php

@@ -10,26 +10,31 @@ abstract class FilterStorageBase implements FilterStorageInterface, \ArrayAccess
     /** @var EntityTypeInterface */
     protected $entityType;
 
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return $this->offsetGet($offset) !== null;
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         return $this->get($offset);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         $this->set($offset, $value);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         $this->remove($offset);
     }
 
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new ArrayIterator($this->getAll());

src/Form/BulkActionForm.php

@@ -140,6 +140,21 @@ public function validateForm(array &$form, FormStateInterface $formState): void
             $subFormState = SubformState::createForSubform($form['configuration']['form'], $form, $formState);
             $entities = $this->getEntities($formState);
 
+            if ($action instanceof ActionInterface) {
+                foreach ($entities as $entity) {
+                    if (!$action->access($entity)) {
+                        $formState->setErrorByName(
+                            sprintf('%s:%s', $entity->getEntityTypeId(), $entity->bundle()),
+                            sprintf(
+                                '"%s" is not allowed in "%s" Bulk operation',
+                                $entity->label(),
+                                (string) ($action->getPluginDefinition()['label'] ?? $action->getPluginId())
+                            )
+                        );
+                    }
+                }
+            }
+
             if ($action instanceof PluginFormInterface) {
                 $action->validateConfigurationForm($form, $subFormState);
             }