Fix tests

Author: wieslawsoltes

src/DisposableAnalyzer/Analyzers/DisposalInAllPathsAnalyzer.cs

@@ -5,6 +5,7 @@
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Operations;
 using Microsoft.CodeAnalysis.FlowAnalysis;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
 using DisposableAnalyzer.Helpers;
 using RoslynAnalyzer.Core.ControlFlow;
 
@@ -45,7 +46,7 @@ private void AnalyzeOperationBlockStart(OperationBlockStartAnalysisContext conte
         if (context.OwningSymbol is not IMethodSymbol)
             return;
 
-        var disposableCreations = new List<(ILocalSymbol local, Location location)>();
+        var disposableCreations = new List<(ILocalSymbol local, VariableDeclaratorSyntax? declarator)>();
         var localsNeedingFinally = new HashSet<string>();
 
         // Track disposable creations
@@ -60,7 +61,9 @@ private void AnalyzeOperationBlockStart(OperationBlockStartAnalysisContext conte
             var localSymbol = GetLocalSymbol(creation);
             if (localSymbol != null)
             {
-                disposableCreations.Add((localSymbol, creation.Syntax.GetLocation()));
+                var declaratorSyntax = creation.Syntax.Parent?.Parent as VariableDeclaratorSyntax;
+
+                disposableCreations.Add((localSymbol, declaratorSyntax));
             }
         }, OperationKind.ObjectCreation);
 
@@ -89,7 +92,7 @@ private void AnalyzeOperationBlockStart(OperationBlockStartAnalysisContext conte
             if (methodOperation == null)
                 return;
 
-            foreach (var (local, location) in disposableCreations)
+            foreach (var (local, declarator) in disposableCreations)
             {
                 // Use the comprehensive disposal flow analyzer from core
                 var analysis = _disposalAnalyzer.AnalyzeDisposal(
@@ -100,9 +103,14 @@ private void AnalyzeOperationBlockStart(OperationBlockStartAnalysisContext conte
 
                 if (!analysis.IsDisposedOnAllPaths || localsNeedingFinally.Contains(local.Name))
                 {
+                    var reportLocation = declarator?.Identifier.GetLocation()
+                        ?? FindLocalDeclarator(methodOperation, local)?.Identifier.GetLocation()
+                        ?? local.Locations.FirstOrDefault()
+                        ?? methodOperation.Syntax.GetLocation();
+
                     var diagnostic = Diagnostic.Create(
                         Rule,
-                        location,
+                        reportLocation,
                         local.Name);
                     blockEndContext.ReportDiagnostic(diagnostic);
                 }
@@ -131,6 +139,13 @@ private void AnalyzeOperationBlockStart(OperationBlockStartAnalysisContext conte
         return null;
     }
 
+    private VariableDeclaratorSyntax? FindLocalDeclarator(IOperation methodOperation, ILocalSymbol local)
+    {
+        return methodOperation.Syntax.DescendantNodes()
+            .OfType<VariableDeclaratorSyntax>()
+            .FirstOrDefault(v => v.Identifier.Text == local.Name);
+    }
+
     private static bool FinallyDisposesLocal(IBlockOperation finallyBlock, ILocalSymbol local)
     {
         foreach (var operation in finallyBlock.Descendants())

tests/DisposableAnalyzer.Tests/CodeFixes/MoveDisposalToFinallyCodeFixProviderTests.cs

@@ -59,7 +59,7 @@ void TestMethod()
 }";
 
         var expected = VerifyCS.Diagnostic(DiagnosticIds.DisposalInAllPaths)
-            .WithLocation(9, 13)
+            .WithSpan(9, 22, 9, 63)
             .WithArguments("stream");
 
         await VerifyCS.VerifyCodeFixAsync(code, expected, fixedCode);
@@ -111,7 +111,7 @@ void TestMethod()
 }";
 
         var expected = VerifyCS.Diagnostic(DiagnosticIds.DisposalInAllPaths)
-            .WithLocation(9, 13)
+            .WithSpan(9, 22, 9, 63)
             .WithArguments("stream");
 
         await VerifyCS.VerifyCodeFixAsync(code, expected, fixedCode);