Skip to content

Commit 2905421

Browse files
committed
Revert: Proceed Login CI tests wit all other actions are completed
This never works if jobs are restarted because it waits for itself but the previous login_tests-ci.yml has never started and was marked as failed. Also remove printing the IP. Change-Id: I891a5a9574a47576ef6c5baac9e4370f92d4e350
1 parent 7ce35e6 commit 2905421

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

.github/workflows/login_tests-ci.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,8 @@ env:
1414
PYWIKIBOT_USERNAME: Pywikibot-test
1515

1616
jobs:
17-
wait_for_all:
18-
runs-on: ubuntu-latest
19-
steps:
20-
- name: Wait for all workflows to complete
21-
uses: kachick/wait-other-jobs@v3.8.1
22-
with:
23-
warmup-delay: PT1M
24-
minimum-interval: PT5M
25-
- name: Proceed with tests
26-
run: echo "All workflows have completed. Proceeding with Login CI tests."
2717
run_tests:
2818
runs-on: ${{ matrix.os || 'ubuntu-latest' }}
29-
needs: wait_for_all
3019
timeout-minutes: 30
3120
strategy:
3221
fail-fast: false

.github/workflows/oauth_tests-ci.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ jobs:
7979
pip install mwoauth
8080
pip install packaging
8181
pip install requests
82-
- name: Print public IP of runner
83-
run: |
84-
python -c "import urllib.request; print('Public IP:', urllib.request.urlopen('https://api.ipify.org').read().decode('utf-8'))"
8582
- name: Generate family files
8683
if: ${{ matrix.family == 'wpbeta' }}
8784
run: |

.github/workflows/pywikibot-ci.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,4 @@ jobs:
148148
- name: Check on failure
149149
if: steps.ci_test.outcome == 'failure'
150150
run: |
151-
# Print public IP of runner
152-
python -c "import urllib.request; print('Public IP:', urllib.request.urlopen('https://api.ipify.org').read().decode('utf-8'))"
153151
exit 1

0 commit comments

Comments
 (0)