Fix decoding of SignResponse

Signed-off-by: Wiktor Kwapisiewicz <[email protected]>

Author: wiktor-k

src/agent.rs

@@ -61,8 +61,14 @@ impl Encoder<Message> for MessageCodec {
         len.encode(&mut bytes)?;
 
         item.encode(&mut bytes)?;
-
         dst.put(&*bytes);
+        //use std::io::Write;
+        //let mut file = std::fs::File::create(uuid::Uuid::new_v4().to_string())?;
+        //let mut bytes = Vec::new();
+        //item.encode(&mut bytes)?;
+        //file.write_all(&bytes)?;
+        //drop(file);
+
         Ok(())
     }
 }

src/proto/message.rs

@@ -436,7 +436,7 @@ impl Decode for Message {
             11 => Ok(Self::RequestIdentities),
             12 => Identity::decode_vec(reader).map(Self::IdentitiesAnswer),
             13 => SignRequest::decode(reader).map(Self::SignRequest),
-            14 => Signature::decode(reader).map(Self::SignResponse),
+            14 => reader.read_prefixed(|reader| Signature::decode(reader).map(Self::SignResponse)),
             17 => AddIdentity::decode(reader).map(Self::AddIdentity),
             18 => RemoveIdentity::decode(reader).map(Self::RemoveIdentity),
             19 => Ok(Self::RemoveAllIdentities),

tests/messages/resp-identities-answer.bin

@@ -0,0 +1 @@
+

tests/messages/resp-sign-response.bin

@@ -32,3 +32,6 @@ echo | ssh-add -x
 echo | ssh-add -X
 # AddIdConstrained
 ssh-add -t 2 id_rsa
+
+# clean up the only leftover
+rm -rf id_rsa