Merge pull request #79 from wiktor-k/wiktor/disallow-unwraps

Propagate error if retrieving encoded length fails instead of panic
wiktor-k · Jun 7, 2024 · 04504ab · 04504ab
2 parents fe210c2 + 4986d0b
commit 04504ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/codec.rs b/src/codec.rs
@@ -75,7 +75,7 @@ where
     fn encode(&mut self, item: Output, dst: &mut BytesMut) -> Result<(), Self::Error> {
         let mut bytes = Vec::new();
 
-        let len = item.encoded_len().unwrap() as u32;
+        let len = item.encoded_len().map_err(ProtoError::SshEncoding)? as u32;
         len.encode(&mut bytes).map_err(ProtoError::SshEncoding)?;
 
         item.encode(&mut bytes).map_err(ProtoError::SshEncoding)?;

diff --git a/src/lib.rs b/src/lib.rs
@@ -2,6 +2,7 @@
 #![deny(missing_debug_implementations)]
 #![deny(unsafe_code)]
 #![deny(missing_docs)]
+#![deny(clippy::unwrap_used)]
 
 pub mod proto;