rework KeyConstaint decoder

baloo · wiktor-k · commit a1c0beb7c6db · 2024-04-05T08:45:45.000+02:00
Signed-off-by: Arthur Gautier &lt;arthur.gautier@arista.com&gt;
diff --git a/src/proto/message.rs b/src/proto/message.rs
@@ -239,8 +239,7 @@ impl Decode for KeyConstraint {
             2 => KeyConstraint::Confirm,
             255 => {
                 let name = String::decode(reader)?;
-                let mut details = vec![0; reader.remaining_len()];
-                reader.read(&mut details)?;
+                let details: Vec<u8> = Vec::decode(reader)?;
                 KeyConstraint::Extension(name, details.into())
             }
             _ => return Err(Error::AlgorithmUnknown)?, // FIXME: it should be our own type
@@ -560,7 +559,6 @@ mod tests {
     }
 
     #[test]
-    #[ignore = "temporarily disable until test vectors are updated"]
     fn test_add_identity_constrained() {
         let msg: &[u8] = &hex!(
             "

Original file line number	Diff line number	Diff line change
`@@ -239,8 +239,7 @@ impl Decode for KeyConstraint {`
`239`	`239`	`2 => KeyConstraint::Confirm,`
`240`	`240`	`255 => {`
`241`	`241`	`let name = String::decode(reader)?;`
`242`		`- let mut details = vec![0; reader.remaining_len()];`
`243`		`- reader.read(&mut details)?;`
	`242`	`+ let details: Vec<u8> = Vec::decode(reader)?;`
`244`	`243`	`KeyConstraint::Extension(name, details.into())`
`245`	`244`	`}`
`246`	`245`	`_ => return Err(Error::AlgorithmUnknown)?, // FIXME: it should be our own type`
`@@ -560,7 +559,6 @@ mod tests {`
`560`	`559`	`}`
`561`	`560`
`562`	`561`	`#[test]`
`563`		`- #[ignore = "temporarily disable until test vectors are updated"]`
`564`	`562`	`fn test_add_identity_constrained() {`
`565`	`563`	`let msg: &[u8] = &hex!(`
`566`	`564`	`"`