Address code review: simplify exception handling and warn on cleanup failures

- Replace catch (Exception e) + instanceof chain with catch (StartException | RuntimeException e) + throw e, using Java's precise rethrow so each exception type is raised as-is with no wrapping and no loss of suppressed exceptions.
- Add LOGGER.failedToCleanupGrpcResources (WFLYGRPC-0013, WARN) to runSafely() so exceptions swallowed during stop() are visible in the server log rather than silently discarded.
- Fix comment typo: 'service sof' -> 'services of'.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Author: jmesnil

subsystem/src/main/java/org/wildfly/extension/grpc/_private/GrpcLogger.java

@@ -52,4 +52,8 @@ public interface GrpcLogger extends BasicLogger {
     @LogMessage(level = WARN)
     @Message(id = 12, value = "Weld capability not available for deployment %s; CDI injection will not be available for gRPC services.")
     void weldCapabilityUnavailable(@Cause Throwable cause, String deploymentName);
+
+    @LogMessage(level = WARN)
+    @Message(id = 13, value = "Exception during gRPC service cleanup; resources may not have been fully released.")
+    void failedToCleanupGrpcResources(@Cause Throwable cause);
 }

subsystem/src/main/java/org/wildfly/extension/grpc/deployment/GrpcDeploymentService.java

@@ -59,20 +59,17 @@ class GrpcDeploymentService implements Service {
     public void start(final StartContext context) throws StartException {
         final WildFlyGrpcDeploymentRegistry serverService = serverServiceSupplier.get();
         try {
-            // Interceptors are shared across all service sof the deployment — instantiate once, not per service.
+            // Interceptors are shared across all services of the deployment — instantiate once, not per service.
             final List<ServerInterceptor> interceptors = createInterceptors();
             for (Class<? extends BindableService> serviceType : serviceClasses) {
                 final BindableService instance = createInstance(serviceType);
                 LOGGER.debugf("Registering gRPC service %s for deployment %s.", serviceType.getName(), deploymentName);
                 ServerServiceDefinition ssd = serverService.addService(deploymentName, instance, interceptors);
                 registeredServices.add(ssd);
             }
-        } catch (Exception e) {
+        } catch (StartException | RuntimeException e) {
             unregister(serverService, e);
-            if (e instanceof StartException) {
-                throw (StartException) e;
-            }
-            throw new StartException(e);
+            throw e;
         }
     }
 
@@ -97,6 +94,8 @@ private static void runSafely(final Runnable action, final Exception cause) {
         } catch (RuntimeException suppressed) {
             if (cause != null) {
                 cause.addSuppressed(suppressed);
+            } else {
+                LOGGER.failedToCleanupGrpcResources(suppressed);
             }
         }
     }