Simplify approval actions and recreate Auto Link on last-link delete

Author: wilhel1812

src/components/Sidebar.tsx

@@ -21,7 +21,6 @@ import {
   fetchResourceChanges,
   fetchUserById,
   updateUserRole,
-  updateUserApproval,
   type CollaboratorDirectoryUser,
   type CloudUser,
   type ResourceChange,
@@ -1346,22 +1345,6 @@ export function Sidebar() {
     }
   };
 
-  const toggleProfileApproval = async () => {
-    if (!profilePopupUser) return;
-    setProfilePopupBusy(true);
-    setProfilePopupStatus("");
-    try {
-      const updated = await updateUserApproval(profilePopupUser.id, !profilePopupUser.isApproved);
-      setProfilePopupUser(updated);
-      setProfilePopupStatus(`${updated.isApproved ? "Approved" : "Set pending"} ${updated.username}.`);
-    } catch (error) {
-      const message = getUiErrorMessage(error);
-      setProfilePopupStatus(`Approval update failed: ${message}`);
-    } finally {
-      setProfilePopupBusy(false);
-    }
-  };
-
   return (
     <aside className="sidebar-panel">
       <UserAdminPanel />
@@ -1650,7 +1633,7 @@ export function Sidebar() {
           </button>
           <button
             className="inline-action"
-            disabled={links.length <= 1}
+            disabled={!links.length}
             onClick={() => deleteLink(selectedLink.id)}
             type="button"
           >
@@ -2073,9 +2056,16 @@ export function Sidebar() {
                   <option value="admin">Admin</option>
                 </select>
               </label>
-              <button className="inline-action" disabled={profilePopupBusy} onClick={() => void toggleProfileApproval()} type="button">
-                {profilePopupUser.isApproved ? "Set Pending" : "Approve Access"}
-              </button>
+              {!profilePopupUser.isApproved ? (
+                <button
+                  className="inline-action"
+                  disabled={profilePopupBusy}
+                  onClick={() => void changeProfileRole("user")}
+                  type="button"
+                >
+                  Approve Access
+                </button>
+              ) : null}
             </div>
             {profilePopupStatus ? <p className="field-help">{profilePopupStatus}</p> : null}
           </div>

src/components/UserAdminPanel.tsx

@@ -377,38 +377,6 @@ export function UserAdminPanel() {
     }
   };
 
-  const toggleApproval = async (user: CloudUser) => {
-    setBusy(true);
-    setStatus("");
-    try {
-      await updateUserRole(user.id, user.isApproved ? "pending" : "user");
-      await refreshAdminData();
-      setStatus(`${user.isApproved ? "Revoked" : "Granted"} access for ${user.username}.`);
-    } catch (error) {
-      const message = getUiErrorMessage(error);
-      setStatus(`Approval update failed: ${message}`);
-    } finally {
-      setBusy(false);
-    }
-  };
-
-  const rejectUser = async (user: CloudUser) => {
-    setBusy(true);
-    setStatus("");
-    try {
-      await updateUserRole(user.id, "pending");
-      await refreshAdminData();
-      setStatus(
-        `${user.isApproved ? "Revoked access for" : "Set pending access for"} ${user.username}.`,
-      );
-    } catch (error) {
-      const message = getUiErrorMessage(error);
-      setStatus(`Reject failed: ${message}`);
-    } finally {
-      setBusy(false);
-    }
-  };
-
   const deleteUserAccount = async (user: CloudUser) => {
     const confirmed = window.confirm(`Delete user ${user.username}? This will remove owned records.`);
     if (!confirmed) return;
@@ -1002,12 +970,15 @@ export function UserAdminPanel() {
                         <option disabled={!canAssignManagedRole(managedUser, "admin")} value="admin">Admin</option>
                       </select>
                     </label>
-                    <button className="inline-action" onClick={() => void toggleApproval(managedUser)} type="button">
-                      {managedUser.isApproved ? "Set Pending" : "Approve Access"}
-                    </button>
-                    <button className="inline-action" onClick={() => void rejectUser(managedUser)} type="button">
-                      Set Pending
-                    </button>
+                    {!managedUser.isApproved ? (
+                      <button
+                        className="inline-action"
+                        onClick={() => void updateRole(managedUser, "user")}
+                        type="button"
+                      >
+                        Approve Access
+                      </button>
+                    ) : null}
                     <button className="inline-action" onClick={() => void deleteUserAccount(managedUser)} type="button">
                       Delete User
                     </button>

src/store/appStore.ts

@@ -646,7 +646,28 @@ export const useAppStore = create<AppState>((set, get) => ({
   deleteLink: (linkId) => {
     set((state) => {
       const remaining = state.links.filter((link) => link.id !== linkId);
-      if (!remaining.length) return state;
+      if (!remaining.length) {
+        if (state.sites.length < 2) return state;
+        const base = state.links[0];
+        const selectedNetwork = state.networks.find((network) => network.id === state.selectedNetworkId);
+        const inheritedFrequencyMHz =
+          selectedNetwork?.frequencyOverrideMHz ?? selectedNetwork?.frequencyMHz ?? base?.frequencyMHz ?? 869.618;
+        const fallbackLink: Link = {
+          id: makeId("lnk"),
+          name: "Auto Link",
+          fromSiteId: state.sites[0].id,
+          toSiteId: state.sites[1].id,
+          frequencyMHz: inheritedFrequencyMHz,
+          txPowerDbm: base?.txPowerDbm ?? 22,
+          txGainDbi: base?.txGainDbi ?? 2,
+          rxGainDbi: base?.rxGainDbi ?? 2,
+          cableLossDb: base?.cableLossDb ?? 1,
+        };
+        return {
+          links: [fallbackLink],
+          selectedLinkId: fallbackLink.id,
+        };
+      }
       return {
         links: remaining,
         selectedLinkId: