Skip to content

Commit 48c6bc1

Browse files
Fix flaky project settings test measurements test (Kitware#3722)
1 parent 97aa76b commit 48c6bc1

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

tests/Browser/Pages/ProjectSettingsPageTest.php

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,8 @@ public function testCanCreateAndDeleteIntegrations(): void
257257
->waitFor('@integrations-tab-link')
258258
->click('@integrations-tab-link')
259259
->whenAvailable('@integrations-tab', function (Browser $browser) use ($branch, $password, $username, $url): void {
260-
$browser->assertButtonDisabled('@create-repository-button')
260+
$browser->waitForText('No integrations configured yet.')
261+
->assertButtonDisabled('@create-repository-button')
261262
->type('@repository-url-input', $url)
262263
->type('@repository-username-input', $username)
263264
->type('@repository-password-input', $password)
@@ -274,8 +275,8 @@ public function testCanCreateAndDeleteIntegrations(): void
274275
->waitFor('@integrations-tab-link')
275276
->click('@integrations-tab-link')
276277
->whenAvailable('@integrations-tab', function (Browser $browser) use ($branch, $username, $url): void {
277-
$browser->assertButtonDisabled('@create-repository-button')
278-
->waitForText($url)
278+
$browser->waitForText($url)
279+
->assertButtonDisabled('@create-repository-button')
279280
->assertSee($username)
280281
->assertSee($branch)
281282
->click('@delete-repository-button')
@@ -289,7 +290,8 @@ public function testCanCreateAndDeleteIntegrations(): void
289290
->waitFor('@integrations-tab-link')
290291
->click('@integrations-tab-link')
291292
->whenAvailable('@integrations-tab', function (Browser $browser) use ($branch, $username, $url): void {
292-
$browser->assertButtonDisabled('@create-repository-button')
293+
$browser->waitForText('No integrations configured yet.')
294+
->assertButtonDisabled('@create-repository-button')
293295
->assertDontSee($url)
294296
->assertDontSee($username)
295297
->assertDontSee($branch)
@@ -321,13 +323,15 @@ public function testCanManageTestMeasurements(): void
321323
->assertSee($m2)
322324
->click('@delete-test-measurement-button')
323325
->waitUntilMissingText($m1)
326+
->waitForText($m2)
324327
->assertSee($m2);
325328
})
326329
->refresh()
327330
->waitFor('@test-measurements-tab-link')
328331
->click('@test-measurements-tab-link')
329332
->whenAvailable('@test-measurements-tab', function (Browser $browser) use ($m1, $m2): void {
330-
$browser->assertSee($m2)
333+
$browser->waitForText($m2)
334+
->assertSee($m2)
331335
->assertDontSee($m1);
332336
});
333337
});

0 commit comments

Comments
 (0)