Recording continues after closing the movie

[RaoOfPhysics]

Hi Will,

Thanks for this useful tool! I noticed the following bug when deploying jupytergraffiti on my computer and then checked that it also occurs on the Binder version of the general demo.

Steps to reproduce:

1. Launch the Binder demo: https://mybinder.org/v2/gh/willkessler/jupytergraffiti/master?filepath=samples%2Fgeneral%2FGraffiti%20Basic%20Demo.ipynb
2. Click on the first graffiti to start the playback.
3. Close the graffiti window by clicking on the red X.

What happens:

The recording continues to play and there is no way out of it without waiting for it to end or refreshing the window.

Expected response:

The graffiti recording stops playing when the recording is closed.

Many thanks,
Achintya

[willkessler]

It looks like something about the docker containers at Binder has changed since I set the binder demos up...

If you press the escape key or the space bar, does playback stop on your computer?

[willkessler]

Actually, on binder, i see why. They are opening these graffitis in jupyterlab. Regrettably, jupytergraffiti was never ported to JupyterLab as the API is totally different. You can only use jupytergraffiti in regular jupyter notebooks. On your computer were you trying it in JupyterLab or Jupyter Notebooks ?

[RaoOfPhysics]

Hi @willkessler! The Binder team have indeed recently changed the defaults to switch to JupyterLab for some inexplicable reason, but I've reported backwards-compatibility issues with it and it appears they're revisiting their decision.

My original report came from the Classic Notebook interface, which was still the default at the time of my filing this issue.

You can still use the Classic Notebook interface by going here: https://mybinder.org/v2/gh/willkessler/jupytergraffiti/master?urlpath=/notebook/samples%2Fgeneral%2FGraffiti%20Basic%20Demo.ipynb

The change is:

- https://mybinder.org/v2/gh/willkessler/jupytergraffiti/master?filepath=samples%2Fgeneral%2FGraffiti%20Basic%20Demo.ipynb
+ https://mybinder.org/v2/gh/willkessler/jupytergraffiti/master?urlpath=/notebook/samples%2Fgeneral%2FGraffiti%20Basic%20Demo.ipynb

I'll try the Graffiti later and report back if it works or not.