Commit ea2fa90
committed
Fix a pending test
Simply removing pending and adjusting the value allowed the test to pass when run individually(e.g., `rspec ./spec/controllers/controller_oauth_spec.rb:93`), but it failed when runnning the whole file (e.g., rspec ./spec/controllers/controller_oauth_spec.rb)
The cause was that the test above was updating `original_callback_url`, and it wasn't beging reset for test next test ( [related code](https://github.com/Sorcery/sorcery/blob/24463e026609072ee51be30a8539a22f97844078/lib/sorcery/controller/submodules/external.rb#L106) ).Resetting `original_callback_url` in each test made the test pass.1 parent 24463e0 commit ea2fa90
1 file changed
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
89 | | - | |
| 90 | + | |
90 | 91 | | |
91 | | - | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | | - | |
| 95 | + | |
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
| 99 | + | |
98 | 100 | | |
99 | 101 | | |
100 | 102 | | |
| |||
0 commit comments