Merge pull request #153 from ncw/fix-no-handler-log

willscott · web-flow · commit 1f025c719ae3 · 2026-05-24T19:07:57.000+02:00
Lower 'No handler' log from Error to Debug for unsupported RPCs
diff --git a/conn.go b/conn.go
@@ -116,7 +116,7 @@ func (c *conn) serializeWrites(ctx context.Context) {
 func (c *conn) handle(ctx context.Context, w *response) error {
 	handler := c.Server.handlerFor(w.req.Header.Prog, w.req.Header.Proc)
 	if handler == nil {
-		Log.Errorf("No handler for %d.%d", w.req.Header.Prog, w.req.Header.Proc)
+		Log.Debugf("No handler for %d.%d", w.req.Header.Prog, w.req.Header.Proc)
 		if err := w.drain(ctx); err != nil {
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ func (c *conn) serializeWrites(ctx context.Context) {`
`116`	`116`	`func (c conn) handle(ctx context.Context, w response) error {`
`117`	`117`	`handler := c.Server.handlerFor(w.req.Header.Prog, w.req.Header.Proc)`
`118`	`118`	`if handler == nil {`
`119`		`- Log.Errorf("No handler for %d.%d", w.req.Header.Prog, w.req.Header.Proc)`
	`119`	`+ Log.Debugf("No handler for %d.%d", w.req.Header.Prog, w.req.Header.Proc)`
`120`	`120`	`if err := w.drain(ctx); err != nil {`
`121`	`121`	`return err`
`122`	`122`	`}`