Commit 4521912
authored
fix: VirtualizedTable event handler types (#92)
Only the return value of `onKeyDown` is used by Zotero. We should mark
the return type of other handlers as `void`:
https://github.com/zotero/zotero/blob/7.0.25/chrome/content/zotero/components/virtualized-table.jsx#L380-L389
Besides, the `onActivate` handler takes not only the event itself, but
also a list of selected items:
https://github.com/zotero/zotero/blob/7.0.25/chrome/content/zotero/components/virtualized-table.jsx#L753-L7601 parent cbad55e commit 4521912
1 file changed
+12
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | | - | |
116 | | - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
117 | 117 | | |
118 | | - | |
119 | | - | |
120 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
289 | 289 | | |
290 | 290 | | |
291 | 291 | | |
292 | | - | |
| 292 | + | |
293 | 293 | | |
294 | | - | |
295 | | - | |
| 294 | + | |
| 295 | + | |
296 | 296 | | |
297 | 297 | | |
298 | | - | |
| 298 | + | |
299 | 299 | | |
300 | | - | |
| 300 | + | |
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| |||
0 commit comments