Address CodeQL: use System.Threading.Lock instead of object for W…
#1603
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| on: [push, pull_request] | |
| name: Continuous Integration | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: true | |
| permissions: | |
| contents: read # to fetch code (actions/checkout) | |
| packages: read # to restore NuGet packages from GitHub Packages | |
| security-events: write # for reporting InspectCode issues | |
| jobs: | |
| inspect-code: | |
| name: Code Quality | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v6 | |
| with: | |
| fetch-depth: 0 | |
| - name: Install .NET 10.0.x | |
| uses: actions/setup-dotnet@v5 | |
| with: | |
| dotnet-version: "10.0.x" | |
| - name: Cache NuGet packages | |
| uses: actions/cache@v5 | |
| with: | |
| path: ~/.nuget/packages | |
| key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj', '**/*.props') }} | |
| restore-keys: ${{ runner.os }}-nuget- | |
| - name: Authenticate to GitHub Packages | |
| run: dotnet nuget update source winnerspiros-github --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text | |
| - name: Restore Tools | |
| run: dotnet tool restore | |
| - name: Restore Packages | |
| run: dotnet restore osu.Desktop.slnf | |
| - name: Restore inspectcode cache | |
| uses: actions/cache@v5 | |
| with: | |
| path: ${{ github.workspace }}/inspectcode | |
| key: inspectcode-${{ hashFiles('.config/dotnet-tools.json', '.github/workflows/ci.yml', 'osu.sln*', 'osu*.slnf', '.editorconfig', '.globalconfig', 'CodeAnalysis/*', '**/*.csproj', '**/*.props') }} | |
| - name: Dotnet code style | |
| run: dotnet build -c Debug -warnaserror osu.Desktop.slnf -p:EnforceCodeStyleInBuild=true | |
| - name: CodeFileSanity | |
| run: | | |
| # TODO: Add ignore filters and GitHub Workflow Command Reporting in CFS. That way we don't have to do this workaround. | |
| # FIXME: Suppress warnings from templates project | |
| exit_code=0 | |
| while read -r line; do | |
| if [[ ! -z "$line" ]]; then | |
| echo "::error::$line" | |
| exit_code=1 | |
| fi | |
| done <<< $(dotnet codefilesanity) | |
| exit $exit_code | |
| - name: InspectCode | |
| uses: JetBrains/ReSharper-InspectCode@v0.12 | |
| with: | |
| tool-version: 2026.1.0.1 | |
| # this is WTF tier but if you don't specify *both* of these the defaults assume `build: true` | |
| build: false | |
| no-build: true | |
| solution: ./osu.Desktop.slnf | |
| caches-home: inspectcode | |
| verbosity: WARN | |
| test: | |
| name: Test | |
| runs-on: ${{matrix.os.fullname}} | |
| env: | |
| OSU_EXECUTION_MODE: ${{matrix.threadingMode}} | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| os: | |
| - { prettyname: Windows, fullname: windows-latest } | |
| # macOS runner performance has gotten unbearably slow so let's turn them off temporarily. | |
| # - { prettyname: macOS, fullname: macos-latest } | |
| - { prettyname: Linux, fullname: ubuntu-latest } | |
| threadingMode: ['SingleThread', 'MultiThreaded'] | |
| timeout-minutes: 120 | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v6 | |
| with: | |
| fetch-depth: 0 | |
| - name: Install .NET 10.0.x | |
| uses: actions/setup-dotnet@v5 | |
| with: | |
| dotnet-version: "10.0.x" | |
| - name: Cache NuGet packages | |
| uses: actions/cache@v5 | |
| with: | |
| path: ~/.nuget/packages | |
| key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj', '**/*.props') }} | |
| restore-keys: ${{ runner.os }}-nuget- | |
| - name: Authenticate to GitHub Packages | |
| run: dotnet nuget update source winnerspiros-github --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text | |
| - name: Compile | |
| run: dotnet build -c Debug -warnaserror osu.Desktop.slnf | |
| - name: Test | |
| continue-on-error: true | |
| run: > | |
| dotnet test | |
| osu.Game.Tests/bin/Debug/**/osu.Game.Tests.dll | |
| osu.Game.Rulesets.Osu.Tests/bin/Debug/**/osu.Game.Rulesets.Osu.Tests.dll | |
| osu.Game.Rulesets.Taiko.Tests/bin/Debug/**/osu.Game.Rulesets.Taiko.Tests.dll | |
| osu.Game.Rulesets.Catch.Tests/bin/Debug/**/osu.Game.Rulesets.Catch.Tests.dll | |
| osu.Game.Rulesets.Mania.Tests/bin/Debug/**/osu.Game.Rulesets.Mania.Tests.dll | |
| osu.Game.Tournament.Tests/bin/Debug/**/osu.Game.Tournament.Tests.dll | |
| Templates/**/*.Tests/bin/Debug/**/*.Tests.dll | |
| --logger "trx;LogFileName=TestResults-${{matrix.os.prettyname}}-${{matrix.threadingMode}}.trx" | |
| -- | |
| NUnit.ConsoleOut=0 | |
| # Attempt to upload results even if test fails. | |
| # https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#cancelled | |
| - name: Upload Test Results | |
| uses: actions/upload-artifact@v7 | |
| if: ${{ !cancelled() }} | |
| with: | |
| name: osu-test-results-${{matrix.os.prettyname}}-${{matrix.threadingMode}} | |
| path: ${{github.workspace}}/TestResults/TestResults-${{matrix.os.prettyname}}-${{matrix.threadingMode}}.trx | |
| test-results: | |
| name: Test results | |
| runs-on: ubuntu-latest | |
| # we want to wait for the `test` job to complete, but run regardless of whether it succeeds or fails | |
| # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#example-not-requiring-successful-dependent-jobs | |
| if: ${{ !cancelled() }} | |
| needs: test | |
| timeout-minutes: 5 | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v6 | |
| - name: Download results | |
| uses: actions/download-artifact@v8 | |
| with: | |
| pattern: osu-test-results-* | |
| merge-multiple: true | |
| - name: Add test results summary to workflow run | |
| uses: dorny/test-reporter@v3.0.0 | |
| with: | |
| name: Results | |
| path: "*.trx" | |
| reporter: dotnet-trx | |
| list-suites: 'failed' | |
| list-tests: 'failed' | |
| use-actions-summary: 'true' | |
| build-only-android: | |
| name: Build only (Android) | |
| runs-on: windows-latest | |
| timeout-minutes: 60 | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v6 | |
| with: | |
| fetch-depth: 0 | |
| - name: Setup JDK 11 | |
| uses: actions/setup-java@v5 | |
| with: | |
| distribution: microsoft | |
| java-version: 11 | |
| - name: Install .NET 10.0.x | |
| uses: actions/setup-dotnet@v5 | |
| with: | |
| dotnet-version: "10.0.x" | |
| - name: Cache NuGet packages | |
| uses: actions/cache@v5 | |
| with: | |
| path: ~/.nuget/packages | |
| key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj', '**/*.props') }} | |
| restore-keys: ${{ runner.os }}-nuget- | |
| - name: Authenticate to GitHub Packages | |
| run: dotnet nuget update source winnerspiros-github --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text | |
| - name: Install .NET workloads | |
| run: dotnet workload install android | |
| - name: Compile | |
| run: dotnet build -c Debug osu.Android.slnf | |
| build-only-ios: | |
| name: Build only (iOS) | |
| runs-on: macos-26 | |
| timeout-minutes: 60 | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v6 | |
| with: | |
| fetch-depth: 0 | |
| - name: Install .NET 10.0.x | |
| uses: actions/setup-dotnet@v5 | |
| with: | |
| dotnet-version: "10.0.x" | |
| - name: Cache NuGet packages | |
| uses: actions/cache@v5 | |
| with: | |
| path: ~/.nuget/packages | |
| key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj', '**/*.props') }} | |
| restore-keys: ${{ runner.os }}-nuget- | |
| - name: Authenticate to GitHub Packages | |
| run: dotnet nuget update source winnerspiros-github --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text | |
| - name: Set Xcode version | |
| run: sudo xcode-select -s /Applications/Xcode_26.3.app | |
| - name: Install .NET Workloads | |
| run: dotnet workload install ios | |
| - name: Build | |
| run: dotnet build -c Debug osu.iOS.slnf |