Commit 18d4348
Bartłomiej Dach
Follow-up fixes for client-side slots implementation (ppy#37868)
Fell out of full-stack testing with
ppy/osu-server-spectator#513.
- **Fix missing property copy in multiplayer client**
Would cause the participant count limit to not update on the multiplayer
match screen.
- **Fix hard crash when user is kicked from a room with slots active**
The kicked user is unsubscribed from receiving room state updates before
their slot is vacated, which then would lead this code to attempt to
look the local, kicked user via the unvacated slot and thus fail because
`client.Room.Users` does *not* contain the user anymore.
This is a bit of a dicey change but I think it's less dicey than to try
to wiggle ordering server-side.1 parent dc3dce5 commit 18d4348
2 files changed
Lines changed: 3 additions & 1 deletion
File tree
- osu.Game
- Online/Multiplayer
- Screens/OnlinePlay/Multiplayer/Participants
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1011 | 1011 | | |
1012 | 1012 | | |
1013 | 1013 | | |
| 1014 | + | |
1014 | 1015 | | |
1015 | 1016 | | |
1016 | 1017 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
0 commit comments