Skip to content

Commit 2111f64

Browse files
authored
Merge pull request #188 from winnerspiros/fix-android-build-trimming-and-x86-3798897346486358961
Fix Android build error MSB4096 and remove x86 support
2 parents 4467dd2 + 899b3e5 commit 2111f64

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
NDK_HOME="$ANDROID_HOME/ndk/29.0.14206865"
5252
CMAKE_BIN="$ANDROID_HOME/cmake/3.22.1/bin/cmake"
5353
54-
for ABI in arm64-v8a armeabi-v7a x86; do
54+
for ABI in arm64-v8a armeabi-v7a; do
5555
echo "::group::Building osu_native for $ABI"
5656
"$CMAKE_BIN" -B "build-native/$ABI" -S osu.Android/Native \
5757
-DCMAKE_TOOLCHAIN_FILE="$NDK_HOME/build/cmake/android.toolchain.cmake" \

osu.Android.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project>
22
<PropertyGroup>
33
<SupportedOSPlatformVersion>33.0</SupportedOSPlatformVersion>
4-
<RuntimeIdentifiers>android-x86;android-arm;android-arm64</RuntimeIdentifiers>
4+
<RuntimeIdentifiers>android-arm;android-arm64</RuntimeIdentifiers>
55
<AndroidPackageFormat>apk</AndroidPackageFormat>
66
<MandroidI18n>CJK;West;</MandroidI18n>
77
<AndroidHttpClientHandlerType>Xamarin.Android.Net.AndroidMessageHandler</AndroidHttpClientHandlerType>
@@ -33,7 +33,7 @@
3333
</PropertyGroup>
3434

3535
<ItemGroup Condition="'$(Configuration)' == 'Release'">
36-
<TrimmerRootAssembly Include="Microsoft.CSharp" />
36+
<TrimmerRootAssembly Include="Microsoft.CSharp" RootMode="all" />
3737
</ItemGroup>
3838

3939
<ItemGroup>

osu.Android/osu.Android.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,5 @@
3131
<ItemGroup>
3232
<AndroidNativeLibrary Include="libs\arm64-v8a\libosu_native.so" Condition="Exists('libs\arm64-v8a\libosu_native.so')" Abi="arm64-v8a" />
3333
<AndroidNativeLibrary Include="libs\armeabi-v7a\libosu_native.so" Condition="Exists('libs\armeabi-v7a\libosu_native.so')" Abi="armeabi-v7a" />
34-
<AndroidNativeLibrary Include="libs\x86\libosu_native.so" Condition="Exists('libs\x86\libosu_native.so')" Abi="x86" />
3534
</ItemGroup>
3635
</Project>

0 commit comments

Comments
 (0)