Fix Android startup crash: don't take OsuConfigManager as BDL param in OsuGameAndroid

OsuConfigManager is cached by OsuGameBase.load into the child dependency container
(via dependencies.CacheAs(LocalConfig) on the container returned by
CreateChildDependencies). The dependency activator, however, resolves BDL
parameters from the parent container passed to InjectDependencies, so requesting
OsuConfigManager as a parameter throws DependencyNotRegisteredException before
the BDL method body runs - crashing the APK on launch.

Use the inherited OsuGameBase.LocalConfig field instead. SetHost creates it
before any BDL runs, so it is guaranteed non-null at this point.

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/81483282-2d9a-4cc8-a6a6-ef10f6020f42

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Android/OsuGameAndroid.cs

@@ -152,8 +152,18 @@ public override Version AssemblyVersion
         /// to drive <see cref="applyAndroidFrameSyncMigrationOnce"/>, the one-shot Android
         /// FrameSync default migration; everything else here is unrelated init wiring.
         /// </summary>
+        /// <remarks>
+        /// We must NOT take <see cref="OsuConfigManager"/> as a BDL parameter here. The
+        /// dependency activator resolves BDL parameters from the parent dependency
+        /// container, but <see cref="OsuGameBase.load"/> caches <c>LocalConfig</c> into
+        /// the child container (the one returned from <c>CreateChildDependencies</c>).
+        /// Resolving <c>OsuConfigManager</c> as a parameter therefore throws
+        /// <c>DependencyNotRegisteredException</c> before this method body even runs.
+        /// Use the inherited <see cref="OsuGameBase.LocalConfig"/> field instead — it is
+        /// guaranteed to be non-null because <c>SetHost</c> creates it before any BDL.
+        /// </remarks>
         [BackgroundDependencyLoader]
-        private void load(FrameworkConfigManager frameworkConfig, OsuConfigManager osuConfig)
+        private void load(FrameworkConfigManager frameworkConfig)
         {
             LocalConfig.BindWith(OsuSetting.AndroidPerformanceMode, performanceMode);
             LocalConfig.BindWith(OsuSetting.AndroidLowLatencyAudio, lowLatencyAudio);
@@ -171,9 +181,9 @@ private void load(FrameworkConfigManager frameworkConfig, OsuConfigManager osuCo
             // AndroidStartupFlags in the activity.
             try
             {
-                osuConfig.BindWith(OsuSetting.AndroidCleanupStaleRealmFifos, cleanupStaleRealmFifos);
-                osuConfig.BindWith(OsuSetting.AndroidDeferStartupNativeInit, deferStartupNativeInit);
-                osuConfig.BindWith(OsuSetting.AndroidStartupFrameSyncMigrationEnabled, startupFrameSyncMigrationEnabled);
+                LocalConfig.BindWith(OsuSetting.AndroidCleanupStaleRealmFifos, cleanupStaleRealmFifos);
+                LocalConfig.BindWith(OsuSetting.AndroidDeferStartupNativeInit, deferStartupNativeInit);
+                LocalConfig.BindWith(OsuSetting.AndroidStartupFrameSyncMigrationEnabled, startupFrameSyncMigrationEnabled);
 
                 // sentinelOnDisable=true → presence ⇒ "feature disabled". The
                 // safety nets default to ON, so the sentinel is created only