Skip to content

Commit 27312f5

Browse files
Fix build and stability issues on Android and Online screens
- Fixed syntax errors in MatchChatDisplay.cs and MatchLeaderboard.cs where long? was accessed incorrectly. - Resolved CS8602 in TestSceneSoloResultsScreen.cs. - Maintained null guards for RoomID.Value to prevent InvalidOperationException crashes. - Kept Vulkan enablement and JNI surface handling improvements for Android.
1 parent a939c28 commit 27312f5

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

osu.Game.Tests/Visual/Ranking/TestSceneSoloResultsScreen.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public override void SetUpSteps()
6868
foreach (var b in r.All<BeatmapInfo>())
6969
b.Status = BeatmapOnlineStatus.Ranked;
7070
});
71-
importedBeatmap = beatmapManager.GetAllUsableBeatmapSets().FirstOrDefault().Beatmaps.FirstOrDefault();
71+
importedBeatmap = beatmapManager.GetAllUsableBeatmapSets().FirstOrDefault()?.Beatmaps.FirstOrDefault()!;
7272
});
7373
AddStep("clear all scores", () => Realm.Write(r => r.RemoveAll<ScoreInfo>()));
7474
}

osu.Game/Screens/OnlinePlay/Match/Components/MatchChatDisplay.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ private void updateChannel()
4242
if (room.RoomID == null || room.ChannelId == 0)
4343
return;
4444

45-
Channel.Value = channelManager?.JoinChannel(new Channel { Id = room.ChannelId, Type = ChannelType.Multiplayer, Name = $"#lazermp_{room.RoomID?.Value ?? 0}" });
45+
Channel.Value = channelManager?.JoinChannel(new Channel { Id = room.ChannelId, Type = ChannelType.Multiplayer, Name = $"#lazermp_{room.RoomID.Value}" });
4646
}
4747

4848
protected override void Dispose(bool isDisposing)

osu.Game/Screens/OnlinePlay/Match/Components/MatchLeaderboard.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private void fetchInitialScores()
4949
if (room.RoomID == null)
5050
return null;
5151

52-
var req = new GetRoomLeaderboardRequest(room.RoomID?.Value ?? 0);
52+
var req = new GetRoomLeaderboardRequest(room.RoomID.Value);
5353

5454
req.Success += r => Schedule(() =>
5555
{

0 commit comments

Comments
 (0)